Skip to content

Remove snapcast YAML configuration#93547

Merged
MartinHjelmare merged 1 commit into
home-assistant:devfrom
gjohansson-ST:snapcast_import
Jun 5, 2023
Merged

Remove snapcast YAML configuration#93547
MartinHjelmare merged 1 commit into
home-assistant:devfrom
gjohansson-ST:snapcast_import

Conversation

@gjohansson-ST
Copy link
Copy Markdown
Member

@gjohansson-ST gjohansson-ST commented May 25, 2023

Breaking change

Configuring Snapcast via YAML was deprecated in Home Assistant Core 2023.5 and support has now been removed.
The YAML configuration was automatically imported to a config entry by release Home Assistant Core 2023.5. Please remove Snapcast YAML configuration from your configuration.yaml file.

Proposed change

Remove platform yaml snapcast, deprecation started in 2023.5 and is now ended after 2 releases.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @luar123, mind taking a look at this pull request as it has been labeled with an integration (snapcast) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of snapcast can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign snapcast Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@gjohansson-ST gjohansson-ST marked this pull request as draft May 25, 2023 19:17
@luar123
Copy link
Copy Markdown
Contributor

luar123 commented May 25, 2023

Thanks for taking care of this.
Do you think it would be worth to extend the depreciation period by one month, as configflow was added only in 2023.5? What's the policy for this? (I know I set breaks_in_ha_version="2023.6.0" but now I am thinking it might be a good idea to extend it.)

@gjohansson-ST
Copy link
Copy Markdown
Member Author

Thanks for taking care of this. Do you think it would be worth to extend the depreciation period by one month, as configflow was added only in 2023.5? What's the policy for this? (I know I set breaks_in_ha_version="2023.6.0" but now I am thinking it might be a good idea to extend it.)

Hi @luar123
That's why it's in draft as afterwards I have seen it didn't make the cut for 2023.4 so it will not be merged until after 2023.6 release so we maintain 2 releases for deprecation.

@emontnemery emontnemery changed the title Remove platform yaml snapcast Remove snapcast YAML configuration May 26, 2023
@gjohansson-ST gjohansson-ST marked this pull request as ready for review June 5, 2023 16:14
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 40cb933 into home-assistant:dev Jun 5, 2023
@gjohansson-ST gjohansson-ST deleted the snapcast_import branch June 5, 2023 16:28
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants