Add missing constants trigger_typeand condition_type

[Ludy87]

Proposed change

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes binary_sensor: missing charging/not charging #93317
• This PR is related to issue: binary_sensor: missing charging/not charging #93317
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (binary_sensor) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of binary_sensor can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign binary_sensor Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[emontnemery]

Thanks @Ludy87 👍

We should maybe generate the lists instead of hardcoding them though?

[emontnemery]

Could we maybe generate these instead to avoid this happening again?

TURNED_ON = [trigger[0] for trigger in ENTITY_TRIGGERS.values()]
TURNED_OFF= [trigger[1] for trigger in ENTITY_TRIGGERS.values()]

[Ludy87]

It would be a good idea, I'm not that proficient in python yet.

[Ludy87]

Should I update the PR?

[emontnemery]

Yes, please 👍

You can run the binary_sensor tests to verify it's working:

pytest -vvx tests/components/binary_sensor/

[Ludy87]

This would work after running the audit

TURNED_ON = [trigger[0]["type"] for trigger in ENTITY_TRIGGERS.values()]
TURNED_OFF = [trigger[1]["type"] for trigger in ENTITY_TRIGGERS.values()]

[frenck]

Removed from milestone, please re-add when the requested change has been made.

I've marked this PR, as changes are requested that need to be processed.
Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

Learn more about our pull request process.

[emontnemery]

Thanks a lot @Ludy87 👍