Skip to content

Fixed Abode device discovery bug#9311

Merged
balloob merged 1 commit into
home-assistant:devfrom
MisterWil:dev
Sep 6, 2017
Merged

Fixed Abode device discovery bug#9311
balloob merged 1 commit into
home-assistant:devfrom
MisterWil:dev

Conversation

@MisterWil
Copy link
Copy Markdown
Contributor

@MisterWil MisterWil commented Sep 5, 2017

Description:

After the last Abode PR was merged a change was made that broke device discovery. This fixes that issue.

This issue is already fixed in the feature pull request #9310 however I wanted to ensure that if that PR did not make it in for 0.53 that this fix did.

Related issue (if applicable): fixes bug introduced in #9095

Pull request in home-assistant.github.io with documentation (if applicable): Not applicable

Example entry for configuration.yaml (if applicable): Not applicable

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link
Copy Markdown

@MisterWil, thanks for your PR! By analyzing the history of the files in this pull request, we identified @arsaboo to be a potential reviewer.

@MisterWil MisterWil changed the title Fixed bug with devices not being discovered correctly. Fixed Abode device discovery big Sep 5, 2017
@MisterWil MisterWil changed the title Fixed Abode device discovery big Fixed Abode device discovery bug Sep 5, 2017
@balloob balloob merged commit 894200d into home-assistant:dev Sep 6, 2017
@balloob balloob mentioned this pull request Sep 7, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants