Fixed Abode device discovery bug#9311
Merged
Merged
Conversation
|
@MisterWil, thanks for your PR! By analyzing the history of the files in this pull request, we identified @arsaboo to be a potential reviewer. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
After the last Abode PR was merged a change was made that broke device discovery. This fixes that issue.
This issue is already fixed in the feature pull request #9310 however I wanted to ensure that if that PR did not make it in for 0.53 that this fix did.
Related issue (if applicable): fixes bug introduced in #9095
Pull request in home-assistant.github.io with documentation (if applicable): Not applicable
Example entry for
configuration.yaml(if applicable): Not applicableChecklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass