MPD small improvements#9301
Merged
Merged
Conversation
Contributor
|
@pdanilew, thanks for your PR! By analyzing the history of the files in this pull request, we identified @StevenLooman, @fabaff and @armills to be potential reviewers. |
houndci-bot
reviewed
Sep 4, 2017
| PLAYLIST_UPDATE_INTERVAL = timedelta(seconds=120) | ||
|
|
||
| SUPPORT_MPD = SUPPORT_PAUSE | SUPPORT_VOLUME_SET | \ | ||
| SUPPORT_MPD = SUPPORT_PAUSE | SUPPORT_VOLUME_SET | SUPPORT_VOLUME_STEP | SUPPORT_VOLUME_MUTE | \ |
andrey-git
requested changes
Sep 5, 2017
| """Return the media state.""" | ||
| if self._status is None: | ||
| return STATE_OFF | ||
| self.update() |
Contributor
There was a problem hiding this comment.
This will cause network access in property
Contributor
Author
There was a problem hiding this comment.
Updated + corrected auto check things.
Contributor
Author
|
Corrected all issues. |
Member
|
@balloob is that okay to fake mute function that not exists on device api or should that implement into device api (python-mpd2)? |
Contributor
Author
|
There is no turn off option either. Does it mean this device should be only start/stop? |
Member
|
It's okay to implement fake mute in here. |
Member
|
Thanks! And congratulations on your first merged PR! 🎉 🐬 |
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Restores power button for MPD and adds mute + volume step buttons in details window.
Checklist:
If user exposed functionality or configuration variables are added/changed:
Documentation added/updated in home-assistant.github.io
Not required. Internal changes.
Local tests with
toxrun successfully. Your PR cannot be merged unless tests passTested on RPI3.
New dependencies have been added to the
REQUIREMENTSvariable (example).None.
New dependencies are only imported inside functions that use them (example).
None.
New dependencies have been added to
requirements_all.txtby runningscript/gen_requirements_all.py.None.
New files were added to
.coveragerc.None.