Skip to content

YoLink Power Failure Alarm #91934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emontnemery merged 5 commits into from
May 25, 2023
Merged

YoLink Power Failure Alarm #91934

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e72cef
add ys-7106
matrixd2 Apr 23, 2023
f9a5dc4
expose mute property
matrixd2 Apr 23, 2023
d7d8843
add volume entity description
matrixd2 Apr 24, 2023
1407ec3
add beep entity description
matrixd2 Apr 24, 2023
8dec944
fix as suggest
matrixd2 May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/yolink/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
"dependencies": ["auth", "application_credentials"],
"documentation": "https://www.home-assistant.io/integrations/yolink",
"iot_class": "cloud_push",
"requirements": ["yolink-api==0.2.8"]
"requirements": ["yolink-api==0.2.9"]
}
46 changes: 46 additions & 0 deletions homeassistant/components/yolink/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
ATTR_DEVICE_MOTION_SENSOR,
ATTR_DEVICE_MULTI_OUTLET,
ATTR_DEVICE_OUTLET,
ATTR_DEVICE_POWER_FAILURE_ALARM,
ATTR_DEVICE_SIREN,
ATTR_DEVICE_SMART_REMOTER,
ATTR_DEVICE_SWITCH,
Expand Down Expand Up @@ -71,6 +72,7 @@ class YoLinkSensorEntityDescription(
ATTR_DEVICE_MULTI_OUTLET,
ATTR_DEVICE_SMART_REMOTER,
ATTR_DEVICE_OUTLET,
ATTR_DEVICE_POWER_FAILURE_ALARM,
ATTR_DEVICE_SIREN,
ATTR_DEVICE_SWITCH,
ATTR_DEVICE_TH_SENSOR,
Expand All @@ -86,6 +88,7 @@ class YoLinkSensorEntityDescription(
ATTR_DEVICE_DOOR_SENSOR,
ATTR_DEVICE_LEAK_SENSOR,
ATTR_DEVICE_MOTION_SENSOR,
ATTR_DEVICE_POWER_FAILURE_ALARM,
ATTR_DEVICE_SMART_REMOTER,
ATTR_DEVICE_TH_SENSOR,
ATTR_DEVICE_VIBRATION_SENSOR,
Expand All @@ -110,6 +113,14 @@ def cvt_battery(val: int | None) -> int | None:
return 0


def cvt_volume(val: int | None) -> str | None:
"""Convert volume to string."""
if val is None:
return None
volume_level = {1: "low", 2: "medium", 3: "high"}
return volume_level.get(val, None)


SENSOR_TYPES: tuple[YoLinkSensorEntityDescription, ...] = (
YoLinkSensorEntityDescription(
key="battery",
Expand Down Expand Up @@ -157,6 +168,41 @@ def cvt_battery(val: int | None) -> int | None:
entity_registry_enabled_default=False,
should_update_entity=lambda value: value is not None,
),
YoLinkSensorEntityDescription(
key="state",
device_class=SensorDeviceClass.ENUM,
name="State",

@emontnemery emontnemery May 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a vague name, maybe name it "Power failure alarm"?

icon="mdi:flash",
options=["normal", "alert", "off"],
exists_fn=lambda device: device.device_type in ATTR_DEVICE_POWER_FAILURE_ALARM,
),
YoLinkSensorEntityDescription(
key="mute",
device_class=SensorDeviceClass.ENUM,
name="Mute",

@emontnemery emontnemery May 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above about this possibly being too vague

icon="mdi:volume-mute",
options=["yes", "no"],
exists_fn=lambda device: device.device_type in ATTR_DEVICE_POWER_FAILURE_ALARM,
value=lambda value: "yes" if value is True else "no",

@emontnemery emontnemery May 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not a control but a sensor, should the states be "muted" and "unmuted"?

@matrixd2 matrixd2 May 24, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a physical mute button on the device, This entity is used to show whether the device is in silent mode

),
YoLinkSensorEntityDescription(
key="sound",
device_class=SensorDeviceClass.ENUM,
name="Volume",

@emontnemery emontnemery May 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above about this possibly being too vague

icon="mdi:volume-high",
options=["low", "medium", "high"],
exists_fn=lambda device: device.device_type in ATTR_DEVICE_POWER_FAILURE_ALARM,
value=cvt_volume,
),
YoLinkSensorEntityDescription(
key="beep",
device_class=SensorDeviceClass.ENUM,
name="Beep",

@emontnemery emontnemery May 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above about this possibly being too vague

icon="mdi:bullhorn",
options=["enable", "disable"],
exists_fn=lambda device: device.device_type in ATTR_DEVICE_POWER_FAILURE_ALARM,
value=lambda value: "enable" if value is True else "disable",

@emontnemery emontnemery May 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not a control but a sensor, should the states be "enabled" and "disabled"?

@matrixd2 matrixd2 May 24, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our API does not support change the settings of the beeper, but the mobile application can , this entity is used to display the status of the beeper

),
)


Expand Down
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2694,7 +2694,7 @@ yeelight==0.7.10
yeelightsunflower==0.0.10

# homeassistant.components.yolink
yolink-api==0.2.8
yolink-api==0.2.9

# homeassistant.components.youless
youless-api==1.0.1
Expand Down
2 changes: 1 addition & 1 deletion requirements_test_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1946,7 +1946,7 @@ yalexs==1.3.0
yeelight==0.7.10

# homeassistant.components.yolink
yolink-api==0.2.8
yolink-api==0.2.9

# homeassistant.components.youless
youless-api==1.0.1
Expand Down