Add h264_v4l2m2m codec and profiles to HomeKit cameras#91246
Merged
Conversation
home-assistant
Bot
added
cla-signed
has-tests
integration: homekit
new-feature
small-pr
Contributor
|
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
Added support for the `h264_v4l2m2m` codec to utilize, among others,
the Raspberry Pi's hardware h.264 encoder. Unfortunately, the
implementation of the Pi's encoder doesn't use the standard h.264
profile names but expects a numerical value:
$ v4l2-ctl --list-ctrls-menu -d 11
h264_profile 0x00990a6b (menu) : min=0 max=4 default=4 value=4
0: Baseline
1: Constrained Baseline
2: Main
4: High
To support that, this commit also adds the option to override the
default profile names used when passed to the FFmpeg encoding process.
shmuelzon
force-pushed
the
add_homekit_rpi_transcoding
branch
from
dad2679 to
c501f85
Compare
Member
|
Looks good. Will pull it on to my production to do a quick sanity check for breakage, but I don't expect any |
bdraco
added
the
smash
Member
|
Testing looks good. No unexpected breakage 👍 |
Contributor
Author
|
Thank you @bdraco for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
None that I can think of.
Proposed change
Added support for the
h264_v4l2m2mcodec to utilize, among others, the Raspberry Pi's hardware h.264 encoder. Unfortunately, the implementation of the Pi's encoder doesn't use the standard h.264 profile names but expects a numerical value:To support that, this commit also adds the option to override the
default profile names used when passed to the FFmpeg encoding process.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: