Skip to content

Support unknown state, position or tilt for template cover#91172

Merged
jbouwh merged 2 commits into
home-assistant:devfrom
jbouwh:template-cover
Apr 12, 2023
Merged

Support unknown state, position or tilt for template cover#91172
jbouwh merged 2 commits into
home-assistant:devfrom
jbouwh:template-cover

Conversation

@jbouwh
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh commented Apr 10, 2023

Proposed change

Allow the state, current_cover_position or current_cover_tilt_position to be unknown. Without the PR an error will be logged, reporting an invalid state update.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @PhracturedBlue, @tetienne, @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (template) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of template can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign template Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Copy Markdown
Contributor

@tetele tetele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the following config, working well.

cover:
  - platform: template
    covers:
      garage_door:
        device_class: garage
        friendly_name: "Garage Door"
        position_template: "{{ None }}"
        tilt_template: "{{ None }}"
        open_cover:
          service: input_boolean.turn_on
          data:
            entity_id: input_boolean.cover_switch
        close_cover:
          service: input_boolean.turn_off
          data:
            entity_id: input_boolean.cover_switch

@jbouwh jbouwh merged commit 722b991 into home-assistant:dev Apr 12, 2023
@jbouwh jbouwh deleted the template-cover branch April 12, 2023 19:23
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

template.cover reports bogus errors but only for one item and only when you reload manually configured mqtt items

3 participants