Skip to content

DHT Catch KeyError #9096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ulf-de wants to merge 1 commit into from
Closed

DHT Catch KeyError #9096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions homeassistant/components/sensor/dht.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,23 @@ def update(self):
data = self.dht_client.data

if self.type == SENSOR_TEMPERATURE:
temperature = data[SENSOR_TEMPERATURE]
try:
temperature = data[SENSOR_TEMPERATURE]
except KeyError:
_LOGGER.error("Error reading temperature data")
return
Copy link
Copy Markdown
Member

@balloob balloob Aug 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the situation when the returned data contains humidity data but no temperature data.

_LOGGER.debug("Temperature %.1f \u00b0C + offset %.1f",
temperature, temperature_offset)
if (temperature >= -20) and (temperature < 80):
self._state = round(temperature + temperature_offset, 1)
if self.temp_unit == TEMP_FAHRENHEIT:
self._state = round(celsius_to_fahrenheit(temperature), 1)
elif self.type == SENSOR_HUMIDITY:
humidity = data[SENSOR_HUMIDITY]
try:
humidity = data[SENSOR_HUMIDITY]
except KeyError:
_LOGGER.error("Error reading humidity data")
return
_LOGGER.debug("Humidity %.1f%% + offset %.1f",
humidity, humidity_offset)
if (humidity >= 0) and (humidity <= 100):
Expand Down