Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added insteonplm device_override multiple capabilities #9078

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Added insteonplm device_override multiple capabilities #9078

merged 1 commit into from
Aug 22, 2017

Conversation

teharris1
Copy link
Contributor

Description:

Some older devices do not repsond to auto discovery correctly. The insteonplm device_override configuration setting allows for these devices to be configured with the correct capabilities. This change allows for multiple capabilities to be added to a single device to better support these items.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

insteon_plm:
  port: /dev/insteon
  device_override:
    - address: '2c3832'
      platform: 
        - light
        - dimmable

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link

@teharris1, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @nugget and @fabaff to be potential reviewers.

@andrey-git andrey-git merged commit f6c5e5f into home-assistant:dev Aug 22, 2017
@balloob balloob mentioned this pull request Aug 25, 2017
@teharris1 teharris1 deleted the Insteon_plm-Multi-Capabilities branch October 19, 2017 17:52
@home-assistant home-assistant locked and limited conversation to collaborators Mar 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants