Skip to content

Add translations for Nuki entity name and battery critical state attribute #90772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pree merged 2 commits into from
Apr 4, 2023
Merged

Add translations for Nuki entity name and battery critical state attribute #90772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d717a19
Add translations for Nuki entity name and battery critical state attr…
Nardol Apr 4, 2023
cfa2024
Remove door sensor name
Nardol Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion homeassistant/components/nuki/binary_sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ class NukiDoorsensorEntity(NukiEntity[NukiDevice], BinarySensorEntity):
"""Representation of a Nuki Lock Doorsensor."""

_attr_has_entity_name = True
_attr_name = "Door sensor"
_attr_device_class = BinarySensorDeviceClass.DOOR

@property
Expand Down
1 change: 1 addition & 0 deletions homeassistant/components/nuki/lock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ class NukiDeviceEntity(NukiEntity[_NukiDeviceT], LockEntity):

_attr_has_entity_name = True
_attr_supported_features = LockEntityFeature.OPEN
_attr_translation_key = "nuki_lock"

@property
def unique_id(self) -> str | None:
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/nuki/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class NukiBatterySensor(NukiEntity[NukiDevice], SensorEntity):
"""Representation of a Nuki Lock Battery sensor."""

_attr_has_entity_name = True
_attr_name = "Battery"
_attr_translation_key = "battery"
_attr_native_unit_of_measurement = PERCENTAGE
_attr_device_class = SensorDeviceClass.BATTERY
_attr_entity_category = EntityCategory.DIAGNOSTIC
Expand Down
19 changes: 19 additions & 0 deletions homeassistant/components/nuki/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,24 @@
"title": "Nuki webhook URL uses HTTPS (SSL)",
"description": "The Nuki bridge can not push events to an HTTPS address (SSL), please configure a (local) HTTP address under \"Home Assistant URL\" in the [network settings]({network_link}). The current (local) address is: `{base_url}`, a valid address could, for example, be `http://192.168.1.10:8123` where `192.168.1.10` is the IP of the Home Assistant device"
}
},
"entity": {
"lock": {
"nuki_lock": {
"state_attributes": {
"battery_critical": {
"state": {
"on": "[%key:component::binary_sensor::entity_component::battery::state::on%]",
"off": "[%key:component::binary_sensor::entity_component::battery::state::off%]"
}
}
}
}
},
"sensor": {
"battery": {
"name": "[%key:component::sensor::entity_component::battery::name%]"
}
}
}
}