Skip to content

Add sort list service to Shopping List#90671

Merged
frenck merged 4 commits into
home-assistant:devfrom
mib1185:shopping_list/add-sort-service
Apr 3, 2023
Merged

Add sort list service to Shopping List#90671
frenck merged 4 commits into
home-assistant:devfrom
mib1185:shopping_list/add-sort-service

Conversation

@mib1185
Copy link
Copy Markdown
Member

@mib1185 mib1185 commented Apr 2, 2023

Proposed change

This service allows to sort the shopping list by name. It is also possible to sort in reverse order (descending).
Frontend integration (thus also the websocket) should be done in a separate PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@mib1185

This comment was marked as resolved.

@mib1185 mib1185 force-pushed the shopping_list/add-sort-service branch from ec5e431 to 31f3e47 Compare April 2, 2023 18:35
Comment thread homeassistant/components/shopping_list/__init__.py Outdated
Comment thread homeassistant/components/shopping_list/__init__.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft April 3, 2023 07:21
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Apr 3, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@mib1185 mib1185 force-pushed the shopping_list/add-sort-service branch from 31f3e47 to 87c7851 Compare April 3, 2023 08:23
@mib1185 mib1185 marked this pull request as ready for review April 3, 2023 08:23
@home-assistant home-assistant Bot requested a review from frenck April 3, 2023 08:24
Comment thread tests/components/shopping_list/test_init.py Outdated
Comment thread tests/components/shopping_list/test_init.py Outdated
Comment thread tests/components/shopping_list/test_init.py Outdated
Comment thread tests/components/shopping_list/test_init.py Outdated
Comment thread tests/components/shopping_list/test_init.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft April 3, 2023 18:10
@mib1185 mib1185 marked this pull request as ready for review April 3, 2023 18:51
@home-assistant home-assistant Bot requested a review from frenck April 3, 2023 18:51
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mib1185 👍

../Frenck

@frenck frenck merged commit d4d77d9 into home-assistant:dev Apr 3, 2023
@mib1185 mib1185 deleted the shopping_list/add-sort-service branch April 3, 2023 19:53
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 4, 2023
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core has-tests integration: shopping_list new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants