Add support for Supla garage doors#90593
Merged
epenet merged 5 commits intoApr 3, 2023
Merged
Conversation
Contributor
Contributor
|
Hey there @mwegrzynek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
alh84001
added a commit
to alh84001/home-assistant.io
that referenced
this pull request
Mar 31, 2023
This makes it in-line with home-assistant/core#90593.
7 tasks
alh84001
added a commit
to alh84001/home-assistant.io
that referenced
this pull request
Mar 31, 2023
New channel types are being added in home-assistant/core#90593.
Merged
8 tasks
Contributor
Author
|
Please ignore the first docs PR - it was made on |
5a290b1 to
0b5927b
Compare
alh84001
added a commit
to alh84001/home-assistant.io
that referenced
this pull request
Mar 31, 2023
New channel types are being added in home-assistant/core#90593.
840e41d to
6399d00
Compare
alh84001
added a commit
to alh84001/home-assistant.io
that referenced
this pull request
Apr 3, 2023
New channel types are being added in home-assistant/core#90593.
epenet
reviewed
Apr 3, 2023
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
epenet
requested changes
Apr 3, 2023
Newly supported channel types are - CONTROLLINGTHEGARAGEDOOR, DIMMER, RGBLIGHTING.
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
1e035f4 to
99977c0
Compare
Contributor
|
As a follow-up PR, and before you add a new light platform, I suggest that you create a preliminary PR to rename |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This adds support for
CONTROLLINGTHEGARAGEDOORSupla channel type - it's basically the same as existingCONTROLLINGTHEGATE.Zamel SBW-02device is an example of such a device.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: