Skip to content

Add support for Supla garage doors#90593

Merged
epenet merged 5 commits into
home-assistant:devfrom
alh84001:supla_additional_channel_types
Apr 3, 2023
Merged

Add support for Supla garage doors#90593
epenet merged 5 commits into
home-assistant:devfrom
alh84001:supla_additional_channel_types

Conversation

@alh84001
Copy link
Copy Markdown
Contributor

@alh84001 alh84001 commented Mar 31, 2023

Breaking change

Proposed change

This adds support for CONTROLLINGTHEGARAGEDOOR Supla channel type - it's basically the same as existing CONTROLLINGTHEGATE. Zamel SBW-02 device is an example of such a device.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hi @alh84001

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @mwegrzynek, mind taking a look at this pull request as it has been labeled with an integration (supla) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of supla can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign supla Removes the current integration label and assignees on the pull request, add the integration domain after the command.

alh84001 added a commit to alh84001/home-assistant.io that referenced this pull request Mar 31, 2023
alh84001 added a commit to alh84001/home-assistant.io that referenced this pull request Mar 31, 2023
@alh84001
Copy link
Copy Markdown
Contributor Author

Please ignore the first docs PR - it was made on current, and not on next.

@alh84001 alh84001 force-pushed the supla_additional_channel_types branch 2 times, most recently from 5a290b1 to 0b5927b Compare March 31, 2023 21:41
alh84001 added a commit to alh84001/home-assistant.io that referenced this pull request Mar 31, 2023
@MartinHjelmare MartinHjelmare changed the title Adding support for additional Supla channel types Add more Supla channel types Mar 31, 2023
@alh84001 alh84001 force-pushed the supla_additional_channel_types branch 2 times, most recently from 840e41d to 6399d00 Compare April 3, 2023 08:23
alh84001 added a commit to alh84001/home-assistant.io that referenced this pull request Apr 3, 2023
Comment thread homeassistant/components/supla/__init__.py
Copy link
Copy Markdown
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this PR.

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Apr 3, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft April 3, 2023 10:00
@alh84001 alh84001 marked this pull request as ready for review April 3, 2023 11:37
@home-assistant home-assistant Bot requested a review from epenet April 3, 2023 11:37
@alh84001 alh84001 changed the title Add more Supla channel types Add garage door Supla channel type Apr 3, 2023
@epenet epenet changed the title Add garage door Supla channel type Add support for Supla garage doors Apr 3, 2023
Comment thread homeassistant/components/supla/cover.py Outdated
Comment thread homeassistant/components/supla/__init__.py Outdated
Comment thread homeassistant/components/supla/__init__.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft April 3, 2023 11:40
@alh84001 alh84001 marked this pull request as ready for review April 3, 2023 11:47
@home-assistant home-assistant Bot requested a review from epenet April 3, 2023 11:47
alh84001 and others added 5 commits April 3, 2023 13:52
Newly supported channel types are - CONTROLLINGTHEGARAGEDOOR, DIMMER, RGBLIGHTING.
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@alh84001 alh84001 force-pushed the supla_additional_channel_types branch from 1e035f4 to 99977c0 Compare April 3, 2023 11:52
Copy link
Copy Markdown
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@epenet epenet merged commit 34245a6 into home-assistant:dev Apr 3, 2023
@epenet
Copy link
Copy Markdown
Contributor

epenet commented Apr 3, 2023

As a follow-up PR, and before you add a new light platform, I suggest that you create a preliminary PR to rename SuplaChannel to SuplaEntity and move it to a separate entity.py module

@github-actions github-actions Bot locked and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants