Deprecate imap_content_sensor#90429
Merged
MartinHjelmare merged 13 commits intoApr 3, 2023
Merged
Conversation
42919ee to
f6ff0b1
Compare
8 tasks
MartinHjelmare
requested changes
Mar 29, 2023
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Contributor
Author
|
@MartinHjelmare Created an import flow. If that fails the issue is replaced with a non fixable issue. TODO: Add tests for imap import flow |
This was referenced Mar 30, 2023
MartinHjelmare
requested changes
Mar 31, 2023
Member
|
The rest looks good! |
jbouwh
commented
Mar 31, 2023
MartinHjelmare
requested changes
Apr 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Deprecate the
imap_email_content_integrations. The IMAP server config can be migrated to theimapintegration with a repair flow. Ayamlconfiguration is generated to set up a template sensor and is shown in the flow to allow the user to copy and past the config intoconfiguration.yaml.Base on the original configuration:
The repair flow will look like:

The next step:

If the IMAP config is migrated but the user has not removed the
imap_email_contentconfiguration fromconfiguration.yamlthe next time Home Assistant is started, then a non fixable issue is created.With that warning again is shown how to setup a template sensor with together with the
imapconfig entry.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: