Preliminary support for Matter cover

[hidaris]

Proposed change

This PR adds matter cover control feature. Curtain tilt support has not been added yet.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue: aqara m2 issue matter-js/python-matter-server#225
• Link to documentation pull request: Add matter cover platform home-assistant.io#26857

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hi @hidaris

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[home-assistant]

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[MartinHjelmare]

Please also add tests. See the other platforms for examples of tests using the diagnostic dumps stored as fixtures.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[marcelveldt]

Hi @hidaris do you have time/interest to address the feedback comments or may/can I help you finishing it ?

[hidaris]

Hi @hidaris do you have time/interest to address the feedback comments or may/can I help you finishing it ?

Most of the feedbacks I've fixed locally, but because of the network in my region, the tests I've added don't have environmental testing at the moment, and I'm working on that...

[hidaris]

I added the test, but it keeps telling me I don't have the entity id, I used flag --snapshot-update, but it didn't solve the problem, can anyone tell me what's wrong?

[MartinHjelmare]

If you address the lint issues we can run CI again and see the error message of the pytest tests, and figure out what's wrong. I'm guessing the entity_id may be incorrect.

[hidaris]

If you address the lint issues, we can rerun CI and see the pytest error message and figure out what is wrong. I suspect that the entity_id might be wrong.

I just pushed the fix

[MartinHjelmare]

Please also address the lint issues: ruff, isort and pylint
Click on the jobs to view the logs and what's wrong.

[hidaris]

Please also address the lint issues: ruff, isort and pylint Click on the jobs to view the logs and what's wrong.

Please also address the lint issues: ruff, isort and pylint Click on the jobs to view the logs and what's wrong.

I adjusted the ruff and isort issue, pylint says I have a problem with intflag, I'm not sure if that's a problem

[MartinHjelmare]

The entity_id seems to be cover.longan_link_wncv_da01. It's logged if you read the CI log.

[MartinHjelmare]

Tests are still failing but for another reason now. Not sure what's wrong.

[hidaris]

Tests are still failing but for another reason now. Not sure what's wrong.

It was a problem with the test fixture, available was not set to true, and then I found that the window state tests added to the previous test depended on the operational status of the subscription, which was not updated correctly during the mock, so I removed them.

[MartinHjelmare]

Can't we set the operational status attribute too in the test so we can test all possible states?

[hidaris]

Can't we set the operational status attribute too in the test so we can test all possible states?

Yes, I added it

[hidaris]

CI says docs-missing, does this need to be fixed?

[MartinHjelmare]

Yes, please link a docs PR with an addition of the new platform to the ha_platforms front matter at the top of the page.

https://www.home-assistant.io/integrations/matter/

[hidaris]

Yes, please link a docs PR with an addition of the new platform to the ha_platforms front matter at the top of the page.

https://www.home-assistant.io/integrations/matter/

I just updated the documentation home-assistant/home-assistant.io#26857

[MartinHjelmare]

Looks good!

[marcelveldt]

Awesome, thanks for your contribution !

[hidaris]

@marcelveldt Just wondering if you're working on the Thermostat cluster? I've got some free time next week and was thinking of giving it a shot.

[marcelveldt]

@marcelveldt Just wondering if you're working on the Thermostat cluster? I've got some free time next week and was thinking of giving it a shot.

Yes, I am. I'll drop a PR for that this week.
Which device do you have/own ? Because thermostat/climate devices are pretty extended so would be good to test a few devices

[hidaris]

@marcelveldt Just wondering if you're working on the Thermostat cluster? I've got some free time next week and was thinking of giving it a shot.

Yes, I am. I'll drop a PR for that this week. Which device do you have/own ? Because thermostat/climate devices are pretty extended so would be good to test a few devices

Looking forward to it! As a non-native English speaker, my description of the device may not be entirely accurate, but to me it is a control panel for central air conditioning. In the matter specification, it corresponds to the thermostat under HVAC.