Add "stream" to default_config#90153
Conversation
remove av check from init
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
I discussed it with some other devs and this change is ok to move on 👍 |
|
Looks like this requires some hassfest updates / update of @uvjustin for FYI |
MartinHjelmare
left a comment
There was a problem hiding this comment.
Please run python3 -m script.gen_requirements_all and commit and push the changes.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Please link a docs PR. Then we can merge. |
|
Thanks, everyone! @MartinHjelmare, which documentation should I be updating for this? The home-assistant.io docs for
which now matches this change |
|
@balloob do you want further documentation changes? |
|
oh, looks good indeed. |
Proposed change
This last PR (#89969) got locked, and I'm not sure my last comment was seen about the
av8.0.0release before that happened. Re-opening, and adding the context again here:We do not try to install the
avpackage on startup when resolving the dependencies of the default config. It seems like this is an artifact from beforeavused binary wheels and had a more difficult manual installation process. I see that line indefault_config/__init__.pywas written in 2019, andavwas updated in 2020 to use binary wheels so can now be easily installed withpip(https://pypi.org/project/av/#description)
It took some digging to figure this out for me when adding a generic camera did not work.
The UI showed "unknown error"; the logs showed that it was because
streamwas not set up, which was ultimately becauseavwas not installed, and it did not get auto-installed on startup when reading the config.I think it is safe now to make this change since
av8.0.0release andstreamshould get set up correctly including the install ofav.If you would like to keep it this way for a manual install, I could instead update the documentation here:
https://www.home-assistant.io/integrations/stream/
Maybe with a troubleshooting section or a note about installing
avmanually?Let me know your thoughts.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: