Skip to content

Add device class to ZHA Xiaomi plug "consumer connected" sensor#89476

Merged
dmulcahey merged 1 commit into
home-assistant:devfrom
TheJulianJES:tjj/zha_xiaomi_plug_eu_consumer_connected_sensor_device_class
Mar 10, 2023
Merged

Add device class to ZHA Xiaomi plug "consumer connected" sensor#89476
dmulcahey merged 1 commit into
home-assistant:devfrom
TheJulianJES:tjj/zha_xiaomi_plug_eu_consumer_connected_sensor_device_class

Conversation

@TheJulianJES
Copy link
Copy Markdown
Member

@TheJulianJES TheJulianJES commented Mar 9, 2023

Proposed change

This adds the plug device class for binary sensors that specify if a plug is plugged into a Xiaomi/Aqara EU smart plug.
Small follow-up to: #88194

Also confirmed that this doesn't create a new entity, but that it updates the existing one like expected.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 9, 2023

Hey there @dmulcahey, @Adminiuga, @puddly, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@dmulcahey dmulcahey merged commit d828263 into home-assistant:dev Mar 10, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants