Skip to content

Xiaomi Air Purifier S2 illuminance sensor support#89208

Merged
rytilahti merged 9 commits into
home-assistant:devfrom
kirill578:airpurifier-s2-illuminance-support
Mar 9, 2023
Merged

Xiaomi Air Purifier S2 illuminance sensor support#89208
rytilahti merged 9 commits into
home-assistant:devfrom
kirill578:airpurifier-s2-illuminance-support

Conversation

@kirill578
Copy link
Copy Markdown
Contributor

@kirill578 kirill578 commented Mar 6, 2023

Proposed change

Add sensor illuminance sensor support xiaomi s2 air purifier. The value is capped at 200 lm. The sensor is located on the top of the device.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

The sensors are based on PURIFIER_MIOT_SENSORS with an additional of (ATTR_ILLUMINANCE,). I ended up hardcoding it as I am not sure if the base sensor set will ever change and I am pretty certain there are no other sensors on the device.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 6, 2023

Hey there @rytilahti, @syssi, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of xiaomi_miio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign xiaomi_miio Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Copy Markdown
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward to me, thanks for the PR @kirill578!

Would you mind creating a PR to the upstream, so that also the future versions of the integration will have these sensors automatically exposed? The file which requires changes is https://github.com/rytilahti/python-miio/blob/master/miio/integrations/zhimi/airpurifier/airpurifier.py#L142 and https://python-miio.readthedocs.io/en/latest/contributing.html#status-containers describes the process of adding those decorators.

edit: looks like the docs are completely missing for this device.

@rytilahti rytilahti merged commit d1734bc into home-assistant:dev Mar 9, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants