Telnet switch by multiholle · Pull Request #8913 · home-assistant/core

multiholle · 2017-08-10T17:13:15Z

Description:

New platform telnet switch. Allows to control a device with telnet commands for on and off. Can fetch the state of the device or work as optimistic switch.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3165

Example entry for `configuration.yaml` (if applicable):

switch:
  platform: telnet
  switches:
    projector:
      resource: "host_or_ip"
      command_on: "PWR ON"
      command_off: "PWR OFF"
      command_state: "PWR?"
      value_template: '{{ value == "PWR=01" }}'

Checklist:

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io
New files were added to .coveragerc.

If the code communicates with devices, web services, or third-party tools:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass

emlove

Looks great overall! Just a few small questions/requests.

emlove · 2017-08-11T13:40:18Z

+    vol.Required(CONF_COMMAND_ON): cv.string,
+    vol.Optional(CONF_COMMAND_STATE): cv.string,
+    vol.Optional(CONF_FRIENDLY_NAME): cv.string,
+    vol.Optional(CONF_OPTIMISTIC): cv.boolean,


Can we drop the optimistic configuration and just assume it's optimistic if there's no command state defined, or is there something I'm missing? For example, assumed_state can just be return self._command_state is None.

emlove · 2017-08-11T13:40:45Z

+        """Update device state."""
+        response = self.__telnet_command(self._command_state)
+        if response:
+            _LOGGER.error(


This should be debug level, correct?

emlove · 2017-08-11T13:42:04Z

+        self._optimistic = optimistic
+        self._value_template = value_template
+
+    def __telnet_command(self, command):


Small nitpick, but single underscore prefix is preferred for normal internal methods.

multiholle · 2017-08-13T10:57:22Z

Updated PR.

emlove · 2017-08-13T17:30:50Z

Good to go once the docs PR is up-to-date.

lwis · 2017-08-17T08:38:47Z

Should the encoding be hardcoded to ASCII? Doesn't it depend on what the host is configured to accept?

multiholle · 2017-08-17T08:46:06Z

Here it states that Telnet uses ASCII encoding: http://www.pcmicro.com/netfoss/telnet.html

pvizeli · 2017-08-17T10:21:38Z

+        """Update device state."""
+        response = self._telnet_command(self._command_state)
+        if response:
+            _LOGGER.info(


Don't log this. Maybe a debug but not more.

pvizeli · 2017-08-17T10:24:55Z

I think if someone have a no ASCII Telnet device, he can make a PR for set encoding as options.

fabaff · 2017-08-20T21:00:01Z

+    vol.Required(CONF_COMMAND_OFF): cv.string,
+    vol.Required(CONF_COMMAND_ON): cv.string,
+    vol.Optional(CONF_COMMAND_STATE): cv.string,
+    vol.Optional(CONF_FRIENDLY_NAME): cv.string,


Please use CONF_NAME instead of CONF_FRIENDLY_NAME.

fabaff · 2017-08-20T21:00:03Z

+
+DEFAULT_PORT = 23
+
+SWITCH_SCHEMA = vol.Schema({


Would be nice to keep it ordered.

fabaff · 2017-08-20T21:00:18Z

+
+# pylint: disable=unused-argument
+def setup_platform(hass, config, add_devices, discovery_info=None):
+    """Find and return switches controlled by shell commands."""


Stale docstring.

pvizeli · 2017-08-30T08:02:01Z

Ping @multiholle

multiholle · 2017-08-31T11:06:34Z

I'm quite busy at the moment. I'm trying to get back to the PR next week.

multiholle · 2017-09-13T06:24:32Z

@pvizeli @fabaff I updated the pull request.

elRadix · 2017-09-23T20:29:33Z

How can I use this addon when authentication is required in order to perform the on/off commands
and would I use this addon in order to replace my script with status of the switch ****

#!/usr/bin/expect
spawn telnet 192.168.1.61 2024
expect ">Ready"
send "\r"
send "Pass password \r"
send "Setrelay 34,1 \r" # switch ON
>Relay 34,ON
send "Setrelay 34,0 \r" # switch OFF
>Relay 34,OFF
send "Getrelay 34\r"   # switch status 
>Relay 34,ON

MartinHjelmare · 2017-09-24T05:32:01Z

Please use the forum or chat for support questions.

https://home-assistant.io/help/#communication-channels

Added telnet switch.

b204c72

homeassistant added new-platform platform: switch.telnet cla-signed labels Aug 10, 2017

multiholle mentioned this pull request Aug 10, 2017

Telnet switch docs home-assistant/home-assistant.io#3165

Merged

Marcel Holle added 3 commits August 10, 2017 20:10

Lint.

dd75053

Coverage

e9c4a3d

Added port parameter to Telnet switch.

47e4be0

balloobbot added the platform label Aug 11, 2017

emlove requested changes Aug 11, 2017

View reviewed changes

Removed optimistic attribute from Telnet switch.

0ded0a7

homeassistant added the cla-signed label Aug 13, 2017

Merge remote-tracking branch 'upstream/dev' into feature/telent_switch

961601f

emlove approved these changes Aug 13, 2017

View reviewed changes

pvizeli requested changes Aug 17, 2017

View reviewed changes

fabaff requested changes Aug 20, 2017

View reviewed changes

Code cleanup.

a393c16

homeassistant added the cla-signed label Sep 11, 2017

Merge remote-tracking branch 'upstream/dev' into feature/telent_switch

e80fd7d

pvizeli approved these changes Sep 18, 2017

View reviewed changes

pvizeli merged commit 5851944 into home-assistant:dev Sep 18, 2017

balloob mentioned this pull request Sep 22, 2017

0.54 #9532

Merged

home-assistant locked and limited conversation to collaborators Sep 24, 2017

ghost added integration: telnet and removed platform: switch.telnet labels Mar 21, 2019


		DEFAULT_PORT = 23

		SWITCH_SCHEMA = vol.Schema({

Uh oh!

Conversation

multiholle commented Aug 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

emlove left a comment

Choose a reason for hiding this comment

Uh oh!

emlove Aug 11, 2017

Choose a reason for hiding this comment

Uh oh!

emlove Aug 11, 2017

Choose a reason for hiding this comment

Uh oh!

emlove Aug 11, 2017

Choose a reason for hiding this comment

Uh oh!

multiholle commented Aug 13, 2017

Uh oh!

emlove commented Aug 13, 2017

Uh oh!

lwis commented Aug 17, 2017

Uh oh!

multiholle commented Aug 17, 2017

Uh oh!

pvizeli Aug 17, 2017

Choose a reason for hiding this comment

Uh oh!

pvizeli commented Aug 17, 2017

Uh oh!

fabaff Aug 20, 2017

Choose a reason for hiding this comment

Uh oh!

fabaff Aug 20, 2017

Choose a reason for hiding this comment

Uh oh!

fabaff Aug 20, 2017

Choose a reason for hiding this comment

Uh oh!

pvizeli commented Aug 30, 2017

Uh oh!

multiholle commented Aug 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

multiholle commented Sep 13, 2017

Uh oh!

elRadix commented Sep 23, 2017

Uh oh!

MartinHjelmare commented Sep 24, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

multiholle commented Aug 10, 2017 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):

multiholle commented Aug 31, 2017 •

edited

Loading