Skip to content

Fix check on non numeric custom sensor device classes #89052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 4 commits into from
Mar 2, 2023
Merged

Fix check on non numeric custom sensor device classes #89052

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60469a7
Custom device classes are not numeric
jbouwh Mar 2, 2023
c46d272
Update homeassistant/components/sensor/__init__.py
jbouwh Mar 2, 2023
3fc0dd6
Add test
jbouwh Mar 2, 2023
7a0789b
Update homeassistant/components/sensor/__init__.py
balloob Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions homeassistant/components/sensor/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,15 +271,18 @@ def device_class(self) -> SensorDeviceClass | None:
@property
def _numeric_state_expected(self) -> bool:
"""Return true if the sensor must be numeric."""
device_class = try_parse_enum(SensorDeviceClass, self.device_class)
Comment thread
balloob marked this conversation as resolved.
if device_class in NON_NUMERIC_DEVICE_CLASSES:
return False
if (
self.state_class is not None
or self.native_unit_of_measurement is not None
or self.suggested_display_precision is not None
):
return True
# Sensors with custom device classes are not considered numeric
device_class = try_parse_enum(SensorDeviceClass, self.device_class)
return device_class not in {None, *NON_NUMERIC_DEVICE_CLASSES}
# Sensors with custom device classes will have the device class
# converted to None and are not considered numeric
return device_class is not None

@property
def options(self) -> list[str] | None:
Expand Down