Add longer text strings to mailbox demo to test string truncation #8893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Aug 8, 2017
| @@ -0,0 +1,7 @@ | |||
| Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nam porta, odio vitae volutpat sollicitudin, neque odio lacinia lorem, non auctor metus lorem id arcu. Integer mollis luctus velit id pharetra. In id sagittis metus. Mauris ultricies, lorem et pulvinar ornare, metus augue iaculis enim, ullamcorper dictum ipsum urna sit amet augue. Nunc dapibus libero quis dui semper scelerisque. Nam dapibus feugiat est ac dapibus. Suspendisse sit amet odio ac turpis commodo volutpat ut ut massa. Etiam quam mauris, tincidunt at orci ut, eleifend aliquam sem. | |||
There was a problem hiding this comment.
Let's not include this file but instead just generate some text on the fly. It's ok to be garbage. Otherwise we're going to ship 2.2kB to every user forever just for a demo.
There was a problem hiding this comment.
text = "Lorem ipsum dolor sit amet, consectetur adipiscing elit. " * 10
pvizeli
requested changes
Aug 8, 2017
| for idx in range(0, 10): | ||
| msgtime = int(dt.as_timestamp( | ||
| dt.utcnow()) - 3600 * 24 * (10 - idx)) | ||
| msgtxt = "This is recorded message # %d" % (idx) | ||
| msgtxt = ("Message %d. %s" % |
There was a problem hiding this comment.
Please use the string format function instead '%' -> "Bla {} is {}".format(1, 2)
pvizeli
approved these changes
Aug 8, 2017
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
…me-assistant#8893) * Add longer text strings to mailbox demo to test string truncation in frontend * Remove lorem ipsum txt file * Use format instead of %
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is just a minor change to add longer text messages to the mailbox demo to make it easier to test string truncation in the frontend.
I would like the frontend to show only the 1st 2 lines of a message, and need longer messages to demonstrate that. This code has no other effect, and if the current frontend code is sufficient, maybe no need to pull this change.
The related frontend request is here:
home-assistant/frontend#319
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass