Skip to content

Activate thread integration if thread border routers are present#88551

Merged
Jc2k merged 6 commits into
home-assistant:devfrom
Jc2k:thread_meshcop_discovery
Feb 21, 2023
Merged

Activate thread integration if thread border routers are present#88551
Jc2k merged 6 commits into
home-assistant:devfrom
Jc2k:thread_meshcop_discovery

Conversation

@Jc2k
Copy link
Copy Markdown
Member

@Jc2k Jc2k commented Feb 21, 2023

Proposed change

Based on conversation with @balloob and @emontnemery. It makes sense for users to be able to use this integration if they have any border routers, especially with diagnostics like #88541. It is possible for them to use third party border routers with HA without HA knowing the secret key or creating a merged network with OTBR, and it makes sense that they'd be able to get some diagnostics for those cases.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (thread) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of thread can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign thread Removes the current integration label and assignees on the issue, add the integration domain after the command.

Comment thread homeassistant/components/thread/config_flow.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft February 21, 2023 15:39
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Jc2k Jc2k marked this pull request as ready for review February 21, 2023 15:49
@home-assistant home-assistant Bot requested a review from emontnemery February 21, 2023 15:49
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Jc2k 👍

@Jc2k Jc2k merged commit ce1ef1d into home-assistant:dev Feb 21, 2023
@Jc2k Jc2k deleted the thread_meshcop_discovery branch February 21, 2023 16:22
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants