Skip to content

Add list areas function to template#88441

Merged
frenck merged 4 commits into
home-assistant:devfrom
rokam:features/area_template
Mar 9, 2023
Merged

Add list areas function to template#88441
frenck merged 4 commits into
home-assistant:devfrom
rokam:features/area_template

Conversation

@rokam
Copy link
Copy Markdown
Contributor

@rokam rokam commented Feb 19, 2023

Proposed change

Added a function to return the full list of Area ids.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added cla-signed core new-feature small-pr PRs with less than 30 lines. labels Feb 19, 2023
@rokam rokam marked this pull request as ready for review February 19, 2023 12:39
@rokam rokam requested a review from a team as a code owner February 19, 2023 12:39
Comment thread homeassistant/helpers/template.py
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft February 19, 2023 18:35
@rokam rokam marked this pull request as ready for review March 9, 2023 12:08
@home-assistant home-assistant Bot requested a review from frenck March 9, 2023 12:09
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rokam 👍

Thanks!

../Frenck

@frenck frenck merged commit eed16dc into home-assistant:dev Mar 9, 2023
@rokam rokam deleted the features/area_template branch March 9, 2023 21:59
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 10, 2023
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants