Skip to content

Fix cloud integration with py3.11#88088

Merged
balloob merged 1 commit into
devfrom
cloud_must_use_tasks
Feb 14, 2023
Merged

Fix cloud integration with py3.11#88088
balloob merged 1 commit into
devfrom
cloud_must_use_tasks

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 14, 2023

Proposed change

In py3.11 Passing coroutines is forbidden, use tasks explicitly

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

In py3.11 `Passing coroutines is forbidden, use tasks explicitly`
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration (cloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cloud can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign cloud Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bdraco bdraco mentioned this pull request Feb 14, 2023
53 tasks
@balloob balloob merged commit 85b852d into dev Feb 14, 2023
@balloob balloob deleted the cloud_must_use_tasks branch February 14, 2023 16:31
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants