Skip to content

Add support for triple_push event for Shelly gen2 devices#88081

Merged
bieniu merged 3 commits into
home-assistant:devfrom
bieniu:shelly-triple-push
Feb 15, 2023
Merged

Add support for triple_push event for Shelly gen2 devices#88081
bieniu merged 3 commits into
home-assistant:devfrom
bieniu:shelly-triple-push

Conversation

@bieniu
Copy link
Copy Markdown
Member

@bieniu bieniu commented Feb 14, 2023

Breaking change

Proposed change

Shelly firmware 0.13.0 introduced a new triple_push event. This PR adds support for this event.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @balloob, @thecode, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bieniu
Copy link
Copy Markdown
Member Author

bieniu commented Feb 15, 2023

Thanks @thecode

@bieniu bieniu merged commit cd4ce86 into home-assistant:dev Feb 15, 2023
@bieniu bieniu deleted the shelly-triple-push branch February 15, 2023 09:20
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants