Add stop charge button to renault integration by rodriguestiago0 · Pull Request #88003 · home-assistant/core

rodriguestiago0 · 2023-02-13T13:25:09Z

Breaking change

Proposed change

Add button to stop charging the car

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: Update renault documentation - Add button section home-assistant.io#26260

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2023-02-13T13:25:13Z

Hi @rodriguestiago0

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant · 2023-02-13T13:25:16Z

Hey there @epenet, mind taking a look at this pull request as it has been labeled with an integration (renault) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of renault can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Change the title of the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign renault Removes the current integration label and assignees on the issue, add the integration domain after the command.

epenet

Please remove the service.
If the button works for you, then we can add it. But we cannot add services if a button already exists.

home-assistant · 2023-02-13T13:28:41Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

epenet · 2023-02-13T14:03:10Z

        requires_electricity=True,
    ),
+    RenaultButtonEntityDescription(
+        async_press=lambda x: x.vehicle.set_charge_stop(),


Have you tested this feature?

Feedback on the renault-api library has been inconsistent, and the function doesn't appear to work on all vehicles (does it actually work on yours?)

The service worked on my Dacia Spring. I will test the button today.

Just tested it and worked with my car.

Dacia spring.

Great can you please adjust tests accordingly?

Should we split the renault and dacia integration? For example dacia spring don't allow schedule charge?

Is possible to have a base integration that is common to both and then specific for each brand?

It is the same library so I think it's better to have a single integration.
Even some Renault vehicles don't support schedule charge...
It is better to adjust documentation for this

epenet

I added the tests, and fixed the CI.
Please open a documentation PR, and we are good to go.

rodriguestiago0 · 2023-02-15T10:08:22Z

documentation PR, and we are good to go.

Just check the current documentation, and it has 0 mentions of buttons. what should I add?

epenet · 2023-02-15T10:22:33Z

Just check the current documentation, and it has 0 mentions of buttons. what should I add?

I'm not sure - but definitely needs a section for the available buttons and mention that they do not work for all vehicles.

epenet · 2023-02-15T14:42:19Z

I have re-triggered the workflow. Please do not merge dev again unless there is a pending conflict as it will invalidate the workflow.

epenet

LGTM 👍

epenet · 2023-02-15T16:13:21Z

I repeat myself:

Please do not merge dev again unless there is a pending conflict as it will invalidate the workflow.

Requested changes have been applied

rodriguestiago0 added 3 commits February 13, 2023 13:09

Added service to start/stop charge

84e5b73

Remove comment

561eac0

Fixed service

473fc96

rodriguestiago0 requested a review from epenet as a code owner February 13, 2023 13:25

home-assistant Bot added cla-needed integration: renault new-feature labels Feb 13, 2023

home-assistant Bot assigned epenet Feb 13, 2023

home-assistant Bot added the Quality Scale: platinum label Feb 13, 2023

home-assistant Bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Feb 13, 2023

epenet requested changes Feb 13, 2023

View reviewed changes

frenck previously requested changes Feb 13, 2023

View reviewed changes

Comment thread homeassistant/components/renault/services.yaml Outdated

home-assistant Bot marked this pull request as draft February 13, 2023 13:28

removed service for start/stop charge

74d08ec

epenet requested changes Feb 13, 2023

View reviewed changes

Comment thread homeassistant/components/renault/button.py Outdated

Comment thread homeassistant/components/renault/manifest.json Outdated

rodriguestiago0 and others added 2 commits February 13, 2023 13:59

Remove version

142fd14

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

Format

c1252d6

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

epenet changed the title ~~Renault Integraton: Add service/button stop charge~~ Add stop charge button to renault integration Feb 13, 2023

epenet reviewed Feb 13, 2023

View reviewed changes

Comment thread homeassistant/components/renault/services.yaml Outdated

rodriguestiago0 and others added 3 commits February 13, 2023 14:04

Revert change

3d82028

Fix lint

ed896fb

Add tests

86aff2d

epenet added the docs-missing label Feb 14, 2023

epenet approved these changes Feb 14, 2023

View reviewed changes

home-assistant Bot added the code-owner-approved label Feb 14, 2023

Merge branch 'dev' into add-stop-charge-renault

b2cc6ab

This was referenced Feb 15, 2023

Add button section to renault documentation page home-assistant/home-assistant.io#26259

Closed

Update renault documentation - Add button section home-assistant/home-assistant.io#26260

Merged

rodriguestiago0 requested a review from frenck February 15, 2023 14:25

epenet removed the docs-missing label Feb 15, 2023

epenet marked this pull request as ready for review February 15, 2023 16:07

home-assistant Bot requested a review from epenet February 15, 2023 16:07

epenet approved these changes Feb 15, 2023

View reviewed changes

Merge branch 'dev' into add-stop-charge-renault

a880a3f

epenet merged commit bef5fde into home-assistant:dev Feb 28, 2023

github-actions Bot locked and limited conversation to collaborators Mar 1, 2023

Uh oh!

Conversation

rodriguestiago0 commented Feb 13, 2023 • edited by epenet Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking change

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot commented Feb 13, 2023

Uh oh!

home-assistant Bot commented Feb 13, 2023

Uh oh!

epenet left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

home-assistant Bot commented Feb 13, 2023

Uh oh!

Uh oh!

Uh oh!

epenet Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

rodriguestiago0 Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

rodriguestiago0 Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

epenet Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

rodriguestiago0 Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

epenet Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

epenet left a comment

Choose a reason for hiding this comment

Uh oh!

rodriguestiago0 commented Feb 15, 2023

Uh oh!

epenet commented Feb 15, 2023

Uh oh!

epenet commented Feb 15, 2023

Uh oh!

epenet left a comment

Choose a reason for hiding this comment

Uh oh!

epenet commented Feb 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rodriguestiago0 commented Feb 13, 2023 •

edited by epenet

Loading

epenet left a comment •

edited

Loading