Skip to content

Add battery sensor to Elgato#87680

Merged
MartinHjelmare merged 1 commit into
devfrom
frenck-2023-0284
Feb 8, 2023
Merged

Add battery sensor to Elgato#87680
MartinHjelmare merged 1 commit into
devfrom
frenck-2023-0284

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Feb 8, 2023

Proposed change

This PR adds the sensor platform to the Elgato integration. For now, just a battery sensor, more sensors (and features) will be added in follow-up PRs.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare merged commit 6582367 into dev Feb 8, 2023
@MartinHjelmare MartinHjelmare deleted the frenck-2023-0284 branch February 8, 2023 09:22
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants