Fix LD2410 BLE detection with passive scans#87584
Conversation
|
Hey there @930913, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
I am fairly confused on what is going on here with the manufacturer ID. It appears they are using TomTom's manufacturer ID (256 / 0x100) and the chip vendor Zhuhai Jieli technology Co.,Ltd (1494 / 0x05D6) that is on the board. I think we should probably stick with the chip vendor as the TomTom one is probably a firmware bug (and likely unauthorized). @bdraco are you seeing both in your passive scans or just TomTom (256 / 0x100)? When I take a raw GAP scan I get 0x020106030330AF10FF000107011615092200E7781897D3620CFFD60508004A4C414953444B1109484C4B2D4C4432343130425F44333632 |
|
I only see 256 for both of my test devices |
Interesting, what tool are you using to scan? nRF Connect is showing both for me. I wonder if what you are using is just grabbing the first manufacturer specific data section and ignoring the next one. Probably not a huge harm to using it the way you are above, but it is certainly odd to see two in one GAP profile and maybe they will fix it at some point to just be the valid JZ (1494 / 0x05D6). |
|
I'm just looking at the diagnostics with active scans disabled |
|
I am unable to reproduce with the exact same results after 3 hours of testing. Some interesting findings though. The devices with updated 2.01.x firmware report normally in passive mode and show up as seen below. However my units running the older 1.07.22091516 never showed up at all in passive mode during that time, I will see if it catches it overnight.
Where ble-monitor is a ESP32 setup for passive monitoring only.
And similar here where hci0 is on an Intel NUC also in passive mode. I think this is a good work around for older version(s) of firmware and it looks like the vendor has patched the device. |
|
I think this change will only cover the older firmware. Happy to take another PR after this one to add passive support for newer firmwares if needed |
Proposed change
Fix LD2410 BLE detection with passive scans
The local name doesn't appear to ever be sent passively, however
they can be detected by a combination of manufacturer_data
and service_uuid after a few hours.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: