Skip to content

Fix matter remove config entry device#87571

Merged
MartinHjelmare merged 4 commits into
devfrom
fix-matter-remove-config-entry-device
Feb 6, 2023
Merged

Fix matter remove config entry device#87571
MartinHjelmare merged 4 commits into
devfrom
fix-matter-remove-config-entry-device

Conversation

@MartinHjelmare
Copy link
Copy Markdown
Member

Breaking change

Proposed change

  • Use the correct device identifier pattern to look up the node when removing a device entry for Matter.
  • We forgot to update this code when changing the device identifier in the January cycle.
  • Use a helper to get the node from the device entry, as we need to do the same in the diagnostics platform.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 6, 2023

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign matter Removes the current integration label and assignees on the issue, add the integration domain after the command.

await matter_client.remove_node(node.node_id)
break
matter = get_matter(hass)
await matter.matter_client.remove_node(node.node_id)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a bug in the client library, where it doesn't listen for the EventType.NODE_DELETED and update the cached nodes. This will be solved separately.

@MartinHjelmare MartinHjelmare added this to the 2023.2.3 milestone Feb 6, 2023
@MartinHjelmare MartinHjelmare merged commit f378dcd into dev Feb 6, 2023
@MartinHjelmare MartinHjelmare deleted the fix-matter-remove-config-entry-device branch February 6, 2023 21:41
balloob pushed a commit that referenced this pull request Feb 7, 2023
@balloob balloob mentioned this pull request Feb 7, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants