-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove translations from Core #87543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
force-pushed
the
frenck-2023-0274
branch
from
February 6, 2023 13:42
cfccc60
to
4b70e8d
Compare
emontnemery
reviewed
Feb 6, 2023
Co-authored-by: Erik Montnemery <[email protected]>
balloob
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥 🔥 🔥
Merged
5 tasks
cereal2nd
pushed a commit
to cereal2nd/home-assistant
that referenced
this pull request
Feb 6, 2023
Co-authored-by: Erik Montnemery <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR removes the translation files from Home Assistant Core.
It is being replaced by our translation compiler for development. This will provide English translations, which is sufficient for most tasks.
Main goals:
If one needs all translations, they can be downloaded using the
python -m script.translations download
command locally.Changes in this PR:
This PR is huge (due to deletions), and consists of multiple PRs for reviewing purposes. If you look at it commit by commit, it is actually pretty OK. The one large commit is the removal, I've run the following command, and committed the result for that commit:
rm -f -r ./homeassistant/components/*/translations
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: