Skip to content

Add LD2410BLE support for new firmware version#87507

Merged
balloob merged 3 commits into
home-assistant:devfrom
bencorrado:ld2410_ble_rev2fw
Feb 6, 2023
Merged

Add LD2410BLE support for new firmware version#87507
balloob merged 3 commits into
home-assistant:devfrom
bencorrado:ld2410_ble_rev2fw

Conversation

@bencorrado
Copy link
Copy Markdown
Contributor

@bencorrado bencorrado commented Feb 5, 2023

Proposed change

HLK (the device manufacturer) released a new firmware image version 2.01.23020209 for the LD2410B sensors. One of the changes they made was to the naming scheme for the Bluetooth name. The rest of the features do not appear to be impacted. This PR updates the BLE name that the component looks for to work for both the 1.XX.XXXXXXX firmware and 2.01.XXXXXXXX firmware versions.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes # none
  • This PR is related to issue: none
  • Link to documentation pull request: none

The new firmware can be tested by updating using the HLK app.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 5, 2023

Hi @bencorrado

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 5, 2023

Hey there @930913, mind taking a look at this pull request as it has been labeled with an integration (ld2410_ble) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ld2410_ble can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign ld2410_ble Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bencorrado
Copy link
Copy Markdown
Contributor Author

Here is an example on the HLK app of both the old version and the new firmware version and their names:
image

Here are the unchanged Bluetooth services for the new firmware:
image

Here are the Bluetooth services for the old firmware:
image

Copy link
Copy Markdown
Contributor

@930913 930913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was eyeing the naming suspiciously since the C variant came out. Thanks for submitting this.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Feb 5, 2023

Please run python3 -m script.hassfest in the venv, commit the change, and push

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run python3 -m script.hassfest in the venv, commit the change, and push

@bdraco bdraco added this to the 2023.2.3 milestone Feb 5, 2023
@bencorrado
Copy link
Copy Markdown
Contributor Author

@bdraco Complete, sorry for the trouble, I ran that before and it told me it completed successfully and I failed to add the changes it made!

@balloob balloob merged commit fee6939 into home-assistant:dev Feb 6, 2023
@bencorrado bencorrado deleted the ld2410_ble_rev2fw branch February 6, 2023 23:53
balloob pushed a commit that referenced this pull request Feb 7, 2023
* Updated local_name to reflect the naming scheme in HLK firmware 2.01.23020209

* Adding generated bluetooth file.
@balloob balloob mentioned this pull request Feb 7, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants