Skip to content

Add the correct loggers to velbus manifest.json#87488

Merged
frenck merged 2 commits into
home-assistant:devfrom
cereal2nd:guiDebug
Feb 6, 2023
Merged

Add the correct loggers to velbus manifest.json#87488
frenck merged 2 commits into
home-assistant:devfrom
cereal2nd:guiDebug

Conversation

@cereal2nd
Copy link
Copy Markdown
Contributor

@cereal2nd cereal2nd commented Feb 5, 2023

Proposed change

Add the correct loggers to the velbus manifest file to support GUI based debug

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 5, 2023

Hey there @brefra, mind taking a look at this pull request as it has been labeled with an integration (velbus) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of velbus can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign velbus Removes the current integration label and assignees on the issue, add the integration domain after the command.

Comment thread homeassistant/components/velbus/manifest.json Outdated
bdraco
bdraco previously requested changes Feb 5, 2023
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #87488 (comment)

epenet
epenet previously requested changes Feb 6, 2023
Copy link
Copy Markdown
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if you are re-ordering items in the manifest, can you please set to:

  • "domain"
  • "name"
  • then all others in alphabetical order

It is not yet enforced, but there is a plan to do that soon.

@frenck
Copy link
Copy Markdown
Member

frenck commented Feb 6, 2023

I've marked this PR, as changes are requested that need to be processed.
Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

LOL I just missed that commit. ok nvm this comment :)

@frenck frenck marked this pull request as draft February 6, 2023 16:09
@frenck frenck marked this pull request as ready for review February 6, 2023 16:09
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cereal2nd 👍

../Frenck

@frenck frenck dismissed stale reviews from epenet and bdraco February 6, 2023 16:10

Comments addressed

@frenck frenck merged commit a11a43b into home-assistant:dev Feb 6, 2023
@bdraco bdraco added this to the 2023.2.3 milestone Feb 6, 2023
@cereal2nd cereal2nd deleted the guiDebug branch February 6, 2023 16:24
cereal2nd added a commit to cereal2nd/home-assistant that referenced this pull request Feb 6, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants