Skip to content

Disable uptime sensor by default in Unifi#87484

Merged
Kane610 merged 1 commit into
home-assistant:devfrom
tkdrob:unifi_uptime
Feb 5, 2023
Merged

Disable uptime sensor by default in Unifi#87484
Kane610 merged 1 commit into
home-assistant:devfrom
tkdrob:unifi_uptime

Conversation

@tkdrob
Copy link
Copy Markdown
Contributor

@tkdrob tkdrob commented Feb 5, 2023

Breaking change

Proposed change

The Unifi uptime sensors create a lot of entries in the database. I've witnessed at least a 50% reduction in the database size from about 3.5GB to 1.5GB by disabling them/excluding them from recorder with entity blobs. Perhaps we will one day have a UI element to manage these and have granular control of the purge keep days on an entity or domain basis.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 5, 2023

Hey there @Kane610, mind taking a look at this pull request as it has been labeled with an integration (unifi) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of unifi can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign unifi Removes the current integration label and assignees on the issue, add the integration domain after the command.

@tkdrob tkdrob changed the title Disable Uptime sensor by default in Unifi Disable uptime sensor by default in Unifi Feb 5, 2023
@bdraco bdraco added this to the 2023.2.3 milestone Feb 5, 2023
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Feb 5, 2023

Should be safe to include in a patch since it won't be a breaking change as it only changes it for new installs

Copy link
Copy Markdown
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Most stuff from unifi integration should go this route

@Kane610 Kane610 merged commit d5b2062 into home-assistant:dev Feb 5, 2023
@tkdrob tkdrob deleted the unifi_uptime branch February 5, 2023 18:33
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants