Skip to content

Bump py-synologydsm-api to 2.1.4#87471

Merged
bdraco merged 1 commit into
home-assistant:devfrom
mib1185:synology_dsm/bump-py-synologydsm-api-to-2.1.3
Feb 5, 2023
Merged

Bump py-synologydsm-api to 2.1.4#87471
bdraco merged 1 commit into
home-assistant:devfrom
mib1185:synology_dsm/bump-py-synologydsm-api-to-2.1.3

Conversation

@mib1185
Copy link
Copy Markdown
Member

@mib1185 mib1185 commented Feb 5, 2023

Proposed change

release notes: https://github.com/mib1185/py-synologydsm-api/releases/tag/v2.1.4
diff: mib1185/py-synologydsm-api@v2.1.2...v2.1.4

hopefully the last one 🤞 aiohttp is more different over requests as expected 🙈

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@mib1185 mib1185 added this to the 2023.2.3 milestone Feb 5, 2023
@mib1185 mib1185 requested a review from Quentame as a code owner February 5, 2023 15:23
@home-assistant home-assistant Bot added bugfix cla-signed dependency Pull requests marked as a dependency upgrade integration: synology_dsm Synology DSM small-pr PRs with less than 30 lines. labels Feb 5, 2023
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 5, 2023

Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration (synology_dsm) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of synology_dsm can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign synology_dsm Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Feb 5, 2023

I think you could use the urllib module mib1185/py-synologydsm-api@v2.1.2...v2.1.3#diff-0a0baedca8 instead

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Feb 5, 2023

I'd use

>>> urllib.parse.urlencode(params, safe='', quote_via=urllib.parse.quote)
'user=has%20a%20space'

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Feb 5, 2023

https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urlencode

The resulting string is a series of key=value pairs separated by '&' characters, where both key and value are quoted using the quote_via function. By default, quote_plus() is used to quote the values, which means spaces are quoted as a '+' character and ‘/’ characters are encoded as %2F, which follows the standard for GET requests (application/x-www-form-urlencoded). An alternate function that can be passed as quote_via is quote(), which will encode spaces as %20 and not encode ‘/’ characters. For maximum control of what is quoted, use quote and specify a value for safe.

@mib1185 mib1185 marked this pull request as draft February 5, 2023 16:14
@mib1185 mib1185 force-pushed the synology_dsm/bump-py-synologydsm-api-to-2.1.3 branch from 80b895d to 3157654 Compare February 5, 2023 18:09
@mib1185 mib1185 changed the title Bump py-synologydsm-api to 2.1.3 Bump py-synologydsm-api to 2.1.4 Feb 5, 2023
@mib1185 mib1185 marked this pull request as ready for review February 5, 2023 18:09
@mib1185 mib1185 requested a review from bdraco February 5, 2023 18:09
@bdraco bdraco merged commit 9911dcf into home-assistant:dev Feb 5, 2023
@mib1185 mib1185 deleted the synology_dsm/bump-py-synologydsm-api-to-2.1.3 branch February 5, 2023 19:09
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem with user names containing spaces in Synology DSM

4 participants