Skip to content

Add missing name field to emulated_hue config#87456

Merged
bdraco merged 2 commits into
home-assistant:devfrom
gregoryhaynes:patch-2
Feb 5, 2023
Merged

Add missing name field to emulated_hue config#87456
bdraco merged 2 commits into
home-assistant:devfrom
gregoryhaynes:patch-2

Conversation

@gregoryhaynes
Copy link
Copy Markdown
Contributor

Provide name field as part of configuration data. This improves compatibility with clients that expect that field, such as the Hue Essentials app (www.hueessentials.com).

Proposed change

This change allows the Hue Essentials app (www.hueessentials.com) to successfully add and connect to the emulated Hue bridge. Without this change the app would display an error indicating that the name field was missing and was unable to continue connection.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Provide name field as part of configuration data. This improves compatibility with clients that expect that field, such as the Hue Essentials app (www.hueessentials.com).
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 5, 2023

Hi @gregoryhaynes

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 5, 2023

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (emulated_hue) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of emulated_hue can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign emulated_hue Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Feb 5, 2023

Will give this a test later today.
This will probably fix compatibility with some other implementations as well

@bdraco bdraco changed the title Add name field to create_config_model Add missing name field to emulated_hue config Feb 5, 2023
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a harmony hub since they tend to be the most picky. All good 👍

@bdraco bdraco merged commit 936ffaf into home-assistant:dev Feb 5, 2023
@Thomas-Vos
Copy link
Copy Markdown

Nice! Thanks for fixing this!

shbatm pushed a commit to shbatm/home-assistant-core that referenced this pull request Feb 5, 2023
Co-authored-by: J. Nick Koston <nick@koston.org>
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants