Add missing name field to emulated_hue config#87456
Merged
Merged
Conversation
Provide name field as part of configuration data. This improves compatibility with clients that expect that field, such as the Hue Essentials app (www.hueessentials.com).
Contributor
|
It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Contributor
|
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Member
|
Will give this a test later today. |
bdraco
approved these changes
Feb 5, 2023
Member
bdraco
left a comment
There was a problem hiding this comment.
Tested with a harmony hub since they tend to be the most picky. All good 👍
|
Nice! Thanks for fixing this! |
shbatm
pushed a commit
to shbatm/home-assistant-core
that referenced
this pull request
Feb 5, 2023
Co-authored-by: J. Nick Koston <nick@koston.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide name field as part of configuration data. This improves compatibility with clients that expect that field, such as the Hue Essentials app (www.hueessentials.com).
Proposed change
This change allows the Hue Essentials app (www.hueessentials.com) to successfully add and connect to the emulated Hue bridge. Without this change the app would display an error indicating that the name field was missing and was unable to continue connection.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: