Skip to content

Improve type hints in edl21 #87267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 1 commit into from
Feb 3, 2023
Merged

Improve type hints in edl21 #87267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions homeassistant/components/edl21/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,12 @@ class EDL21:
"129-129:199.130.5*255", # Iskraemeco: Public Key
}

def __init__(self, hass, config, async_add_entities) -> None:
def __init__(
self,
hass: HomeAssistant,
config: ConfigType,
async_add_entities: AddEntitiesCallback,
) -> None:
"""Initialize an EDL21 object."""
self._registered_obis: set[tuple[str, str]] = set()
self._hass = hass
Expand All @@ -301,7 +306,7 @@ def __init__(self, hass, config, async_add_entities) -> None:
self._proto = SmlProtocol(config[CONF_SERIAL_PORT])
self._proto.add_listener(self.event, ["SmlGetListResponse"])

async def connect(self):
async def connect(self) -> None:
"""Connect to an EDL21 reader."""
await self._proto.connect(self._hass.loop)

Expand All @@ -319,7 +324,7 @@ def event(self, message_body) -> None:
return
electricity_id = electricity_id.replace(" ", "")

new_entities = []
new_entities: list[EDL21Entity] = []
for telegram in message_body.get("valList", []):
if not (obis := telegram.get("objName")):
continue
Expand Down Expand Up @@ -352,7 +357,7 @@ def event(self, message_body) -> None:
if new_entities:
self._hass.loop.create_task(self.add_entities(new_entities))

async def add_entities(self, new_entities) -> None:
async def add_entities(self, new_entities: list[EDL21Entity]) -> None:
"""Migrate old unique IDs, then add entities to hass."""
registry = er.async_get(self._hass)

Expand Down