Skip to content

Fix missing property in bosch_shc #87260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 1 commit into from
Feb 3, 2023
+9 −1
Merged

Fix missing property in bosch_shc #87260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion homeassistant/components/bosch_shc/entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,16 @@

from boschshcpy import SHCDevice, SHCIntrusionSystem

from homeassistant.core import HomeAssistant
from homeassistant.helpers.device_registry import async_get as get_dev_reg
from homeassistant.helpers.entity import DeviceInfo, Entity

from .const import DOMAIN


async def async_remove_devices(hass, entity, entry_id) -> None:
async def async_remove_devices(

@MartinHjelmare MartinHjelmare Feb 4, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: This doesn't need to be a coroutine function as there's no await inside.

hass: HomeAssistant, entity: SHCBaseEntity, entry_id: str
) -> None:
"""Get item that is removed from session."""
dev_registry = get_dev_reg(hass)
device = dev_registry.async_get_device(
Expand Down Expand Up @@ -49,6 +52,11 @@ async def async_will_remove_from_hass(self) -> None:
await super().async_will_remove_from_hass()
self._device.unsubscribe_callback(self.entity_id)

@property
def device_id(self) -> str:
"""Return the device id."""
return self._device.id

Comment on lines +55 to +59

@epenet epenet Feb 3, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, async_remove_devices couldn't have worked.

core/homeassistant/components/bosch_shc/entity.py

Lines 15 to 17 in 19b4cf4

device = dev_registry.async_get_device(
identifiers={(DOMAIN, entity.device_id)}, connections=set()
)


class SHCEntity(SHCBaseEntity):
"""Representation of a SHC device entity."""
Expand Down