Add proxy support for telegram_bot #8717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New optional config parameters `proxy_url` and `proxy_params` (a dict)
```yaml
telegram_bot:
platform: polling
api_key: !secret telegram_bot_api_key
allowed_chat_ids:
- !secret telegram_bot_chatid
proxy_url: socks5://proxy_ip:proxy_port
proxy_params:
username: my-username
password: my-secret-password
```
fabaff
reviewed
Jul 30, 2017
| @@ -85,6 +87,8 @@ | |||
| vol.Required(CONF_ALLOWED_CHAT_IDS): | |||
| vol.All(cv.ensure_list, [vol.Coerce(int)]), | |||
| vol.Optional(ATTR_PARSER, default=PARSER_MD): cv.string, | |||
| vol.Optional(ATTR_PROXY_URL): cv.string, | |||
There was a problem hiding this comment.
Is there a reason to prefix configuration constants with ATTR_ instead than CONF_?
There was a problem hiding this comment.
no, my bad. I'll change it
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* Add proxy support for telegram_bot
New optional config parameters `proxy_url` and `proxy_params` (a dict)
```yaml
telegram_bot:
platform: polling
api_key: !secret telegram_bot_api_key
allowed_chat_ids:
- !secret telegram_bot_chatid
proxy_url: socks5://proxy_ip:proxy_port
proxy_params:
username: my-username
password: my-secret-password
```
* change `ATTR_` for `CONF_` for config params
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This feature was requested by a forum user about a month ago (and then also requested privately to my email !!). I did this minimal change for the user and it seems that works ok, but I can't say because I'm not behind a proxy.
The config is done with new optional parameters
proxy_urlandproxy_params(a dict).If approved, I'll update the doc
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed: