Improve typing in plex services#87078
Merged
Merged
Conversation
home-assistant
Bot
added
cla-signed
code-quality
integration: plex
small-pr
Contributor
|
Hey there @jjlawren, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
epenet
commented
Feb 1, 2023
|
|
||
|
|
||
| async def async_setup_services(hass): | ||
| async def async_setup_services(hass: HomeAssistant) -> None: |
Contributor
Author
There was a problem hiding this comment.
The return value was always True, and never checked.
I think it is cleaner to drop the return value.
epenet
commented
Feb 1, 2023
| raise HomeAssistantError("Plex integration not configured") | ||
| plex_servers = hass.data[DOMAIN][SERVERS].values() | ||
| if not plex_servers: | ||
| servers: dict[str, PlexServer] = hass.data[DOMAIN][SERVERS] |
Contributor
Author
There was a problem hiding this comment.
Small change here to first get the full dict, and only get the values() on line 94.
This means we don't need to get the dict again on line 92, and it helps with typing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Linked to #87068
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: