Fix Z-Wave barrier discovery for new API #8706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@armills, thanks for your PR! By analyzing the history of the files in this pull request, we identified @turbokongen, @andrey-git and @balloob to be potential reviewers. |
|
@armills Just tested, working fine on this end. |
balloob
pushed a commit
that referenced
this pull request
Jul 31, 2017
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
ghost
removed
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I got updated to the latest openzwave, and after #8574 there are some problems with zwave cover discovery. This PR broke support for covers that expose themselves as binary switches. The discovery schema also needs to be updated so that the barrier class is controlling the right value.
CC @firstof9 (Can you test this to make sure it still works on your system?)