Shopping List: edit name / complete status #8666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick question: any reason to why this is implemented as a shopping list rather than a more generic "list" component? Would be useful to be able to create other lists (e.g. tasks, todo, etc) 😊 |
pvizeli
reviewed
Jul 27, 2017
| """Add a shopping list item.""" | ||
| self.items.append({ | ||
| 'name': name, | ||
| 'id': str(time()), |
There was a problem hiding this comment.
a ntpd can change time and the counter of that function
balloob
added a commit
that referenced
this pull request
Jul 29, 2017
* Shopping List: edit name / complete status * Change ID to be UUID based
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* Shopping List: edit name / complete status * Change ID to be UUID based
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add an API endpoint to the shopping list to update name/complete status of items.
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass