Skip to content

Add Thread integration#86283

Merged
balloob merged 3 commits into
devfrom
thread_integration
Jan 23, 2023
Merged

Add Thread integration#86283
balloob merged 3 commits into
devfrom
thread_integration

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Jan 20, 2023

Proposed change

Add Thread integration

At this point it does nothing, the purpose is to be able to show a Thread config panel in frontend
In follow-up PRs, the Thread integration will manage Thread credentials

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Comment thread homeassistant/components/thread/config_flow.py Outdated
Comment thread homeassistant/generated/integrations.json Outdated
Comment thread tests/components/thread/test_config_flow.py Outdated
@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 20, 2023

Can you update the name in the OTBR manifest too

@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 20, 2023

And add a dependency on thread in the otbr manifest as that will link to the panel home-assistant/frontend#15150

@emontnemery emontnemery requested a review from a team as a code owner January 20, 2023 13:48
Comment thread tests/components/thread/test_init.py Outdated
Comment thread homeassistant/components/thread/__init__.py Outdated
@balloob balloob merged commit 9ef86b7 into dev Jan 23, 2023
@balloob balloob deleted the thread_integration branch January 23, 2023 15:27
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants