Skip to content

Add panel brightness control for Litter-Robot 4#86269

Merged
emontnemery merged 3 commits into
home-assistant:devfrom
natekspencer:lr4-panel-brightness
Mar 28, 2023
Merged

Add panel brightness control for Litter-Robot 4#86269
emontnemery merged 3 commits into
home-assistant:devfrom
natekspencer:lr4-panel-brightness

Conversation

@natekspencer
Copy link
Copy Markdown
Contributor

@natekspencer natekspencer commented Jan 20, 2023

Proposed change

Add panel brightness control for Litter-Robot 4
pylitterbot bumped to 2023.1.2: https://github.com/natekspencer/pylitterbot/releases/tag/2023.1.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration (litterrobot) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of litterrobot can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign litterrobot Removes the current integration label and assignees on the issue, add the integration domain after the command.

Comment thread homeassistant/components/litterrobot/select.py Outdated
@natekspencer natekspencer force-pushed the lr4-panel-brightness branch 2 times, most recently from 5d617f3 to 89dff6f Compare February 9, 2023 16:39
@natekspencer natekspencer force-pushed the lr4-panel-brightness branch 2 times, most recently from 874aea5 to 2356986 Compare February 21, 2023 18:58
@natekspencer natekspencer force-pushed the lr4-panel-brightness branch from 2356986 to 0b9ebef Compare March 4, 2023 01:09
@natekspencer natekspencer marked this pull request as draft March 4, 2023 02:09
@natekspencer natekspencer marked this pull request as ready for review March 4, 2023 02:10
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 5, 2023
@natekspencer natekspencer force-pushed the lr4-panel-brightness branch from f4e3834 to a080c60 Compare March 6, 2023 19:38
@natekspencer natekspencer force-pushed the lr4-panel-brightness branch from a080c60 to f0994c8 Compare March 8, 2023 19:24
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @natekspencer 👍

@emontnemery emontnemery merged commit cdefc48 into home-assistant:dev Mar 28, 2023
@natekspencer natekspencer deleted the lr4-panel-brightness branch March 29, 2023 01:49
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed dependency Pull requests marked as a dependency upgrade has-tests integration: litterrobot new-feature Quality Scale: No score smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants