Skip to content
Merged
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 37 additions & 22 deletions homeassistant/components/weather/yweather.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@

import homeassistant.helpers.config_validation as cv
from homeassistant.components.weather import (
WeatherEntity, PLATFORM_SCHEMA, ATTR_FORECAST_TEMP)
WeatherEntity, PLATFORM_SCHEMA,
ATTR_FORECAST_TEMP, ATTR_FORECAST_TIME)
from homeassistant.const import (TEMP_CELSIUS, CONF_NAME, STATE_UNKNOWN)

REQUIREMENTS = ["yahooweather==0.8"]
Expand All @@ -21,8 +22,10 @@
ATTR_FORECAST_CONDITION = 'condition'
ATTRIBUTION = "Weather details provided by Yahoo! Inc."

CONF_FORECAST = 'forecast'
ATTR_FORECAST_TEMP_LOW = 'templow'

CONF_WOEID = 'woeid'
CONF_FORECAST = 'forecast'

DEFAULT_NAME = 'Yweather'

Expand All @@ -33,23 +36,31 @@
'fog': [19, 20, 21, 22, 23],
'hail': [17, 18, 35],
'lightning': [37],
'lightning-rainy': [38, 39],
'lightning-rainy': [38, 39, 47],
'partlycloudy': [44],
'pouring': [40, 45],
'rainy': [9, 11, 12],
'snowy': [8, 13, 14, 15, 16, 41, 42, 43],
'snowy-rainy': [5, 6, 7, 10, 46, 47],
'sunny': [32],
'snowy-rainy': [5, 6, 7, 10, 46],
'sunny': [32, 33, 34],
'windy': [24],
'windy-variant': [],
'exceptional': [0, 1, 2, 3, 4, 25, 36],
}

_CONDITION_CLASSES_MAX = 50

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this


CONDITION_CLASSES_LIST = [str(x) for x in range(0, _CONDITION_CLASSES_MAX)]

for cond, condlst in CONDITION_CLASSES.items():
for condi in condlst:
CONDITION_CLASSES_LIST[condi] = cond

PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({
vol.Optional(CONF_WOEID, default=None): cv.string,
vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string,
vol.Optional(CONF_FORECAST, default=0):
vol.All(vol.Coerce(int), vol.Range(min=0, max=5)),
vol.Optional(CONF_FORECAST, default=5):

@pvizeli pvizeli Jul 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't make a breaking change. I see no reason to change this now.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The forecast in yaml works different from the old one, so I think maybe its better to change forecast to something like forecast_days.

vol.All(vol.Coerce(int), vol.Range(min=0, max=10)),
})


Expand Down Expand Up @@ -103,9 +114,8 @@ def name(self):
def condition(self):
"""Return the current condition."""
try:
return [k for k, v in CONDITION_CLASSES.items() if
int(self._data.yahoo.Now['code']) in v][0]
except IndexError:
return CONDITION_CLASSES_LIST[int(self._data.yahoo.Now['code'])]
except (ValueError, IndexError):
return STATE_UNKNOWN

@property
Expand Down Expand Up @@ -138,6 +148,11 @@ def wind_speed(self):
"""Return the wind speed."""
return self._data.yahoo.Wind['speed']

@property
def wind_bearing(self):
"""Return the wind direction."""
return self._data.yahoo.Wind['direction']

@property
def attribution(self):
"""Return the attribution."""
Expand All @@ -146,19 +161,19 @@ def attribution(self):
@property
def forecast(self):
"""Return the forecast array."""
if self._forecast == 0:
return []

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed...CONF_FORECAST will never be None as it defaults to 5 if not provided.

try:
forecast_condition = \
[k for k, v in CONDITION_CLASSES.items() if
int(self._data.yahoo.Forecast[self._forecast]['code'])
in v][0]
except IndexError:
return STATE_UNKNOWN

return [{
ATTR_FORECAST_CONDITION: forecast_condition,
ATTR_FORECAST_TEMP:
self._data.yahoo.Forecast[self._forecast]['high'],
}]
return [
{
ATTR_FORECAST_TIME: v['date'],
ATTR_FORECAST_TEMP:int(v['high']),
ATTR_FORECAST_TEMP_LOW: int(v['low']),
ATTR_FORECAST_CONDITION: CONDITION_CLASSES_LIST[
int(v['code'])]
} for v in self._data.yahoo.Forecast[:self._forecast]]
except (ValueError, IndexError):
return []

def update(self):
"""Get the latest data from Yahoo! and updates the states."""
Expand Down