Skip to content

Add ability to configure map icons for PurpleAir#86124

Merged
bachya merged 5 commits into
home-assistant:devfrom
bachya:purpleair-options-flow
Jun 30, 2023
Merged

Add ability to configure map icons for PurpleAir#86124
bachya merged 5 commits into
home-assistant:devfrom
bachya:purpleair-options-flow

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Jan 17, 2023

Proposed change

This PR adds a Settings option to the PurpleAir options flow, and under it, an option to show or hide entities on the map.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Comment thread homeassistant/components/purpleair/__init__.py Outdated
Comment thread homeassistant/components/purpleair/__init__.py
Comment thread homeassistant/components/purpleair/__init__.py
Comment thread homeassistant/components/purpleair/__init__.py
@bachya bachya added the smash Indicator this PR is close to finish for merging or closing label Apr 5, 2023
@emontnemery
Copy link
Copy Markdown
Contributor

The changes are fine but a rebase is needed

@emontnemery emontnemery marked this pull request as draft June 28, 2023 10:11
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Jun 28, 2023
@bachya bachya force-pushed the purpleair-options-flow branch from 840451c to 69238ad Compare June 28, 2023 18:00
@bachya bachya marked this pull request as ready for review June 28, 2023 18:01
@bachya bachya added the smash Indicator this PR is close to finish for merging or closing label Jun 28, 2023
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bachya 👍

@bachya bachya merged commit 39e0662 into home-assistant:dev Jun 30, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 1, 2023
@bachya bachya deleted the purpleair-options-flow branch October 13, 2023 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants