Add ability to configure map icons for PurpleAir#86124
Merged
Merged
Conversation
bachya
commented
Jan 17, 2023
8 tasks
thecode
reviewed
Jan 17, 2023
thecode
approved these changes
Jan 17, 2023
emontnemery
requested changes
Jan 18, 2023
emontnemery
approved these changes
Jun 28, 2023
Contributor
|
The changes are fine but a rebase is needed |
840451c to
69238ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds a
Settingsoption to the PurpleAir options flow, and under it, an option to show or hide entities on the map.Type of change
Additional information
Settingsoptions flow home-assistant.io#25815Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: