Skip to content

Add repeat options to tplink sequence effect service#86040

Merged
rytilahti merged 1 commit into
home-assistant:devfrom
wparker42:sequence-repeat
Feb 4, 2023
Merged

Add repeat options to tplink sequence effect service#86040
rytilahti merged 1 commit into
home-assistant:devfrom
wparker42:sequence-repeat

Conversation

@wparker42
Copy link
Copy Markdown
Contributor

@wparker42 wparker42 commented Jan 16, 2023

Proposed change

Add the option to set the number of repetitions when calling the sequence effect service. The "repeat_times" variable is already included in the call but currently hard-coded to zero (repeat forever). A use case for finite repetitions would be to set a custom, non-animated color/brightness pattern to a light strip using the sequence list like a list of addressable LEDs.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hi wparker42

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @rytilahti, @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the issue, add the integration domain after the command.

Copy link
Copy Markdown
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR @wparker42! 👍 This can be merged after the documentation is updated, please create a doc PR on the next branch (https://github.com/home-assistant/home-assistant.io/blob/next/source/_integrations/tplink.markdown) and link it to the designated doc PR field in the description.

@rytilahti rytilahti changed the title Add repeat options to sequence effect service Add repeat options to tplink sequence effect service Feb 4, 2023
@rytilahti rytilahti merged commit a703aa1 into home-assistant:dev Feb 4, 2023
@wparker42 wparker42 deleted the sequence-repeat branch February 4, 2023 23:49
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants