Skip to content

Add device_class and state_class to sql#85418

Merged
frenck merged 1 commit into
home-assistant:devfrom
gjohansson-ST:sql-add-classes
Mar 5, 2023
Merged

Add device_class and state_class to sql#85418
frenck merged 1 commit into
home-assistant:devfrom
gjohansson-ST:sql-add-classes

Conversation

@gjohansson-ST
Copy link
Copy Markdown
Member

@gjohansson-ST gjohansson-ST commented Jan 8, 2023

Proposed change

Adds device_class and state_class as configurable options for yaml setup

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 8, 2023

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (sql) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sql can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign sql Removes the current integration label and assignees on the issue, add the integration domain after the command.

@gjohansson-ST
Copy link
Copy Markdown
Member Author

Documentation PR to be added once home-assistant/home-assistant.io#24293 has merged

@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 9, 2023

@gjohansson-ST Referenced docs PR has been merged.

@gjohansson-ST
Copy link
Copy Markdown
Member Author

@frenck docs added

@bdraco bdraco added smash Indicator this PR is close to finish for merging or closing and removed docs-missing labels Jan 21, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gjohansson-ST 👍

../Frenck

@frenck frenck merged commit f4cda2d into home-assistant:dev Mar 5, 2023
@gjohansson-ST gjohansson-ST deleted the sql-add-classes branch March 5, 2023 20:12
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 6, 2023
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed has-tests integration: sql new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL sensor missing device_class and state_class

4 participants