Skip to content

Increase Hydrawise default scan interval#85398

Merged
MartinHjelmare merged 1 commit into
home-assistant:devfrom
mobilutz:patch-1
Jan 8, 2023
Merged

Increase Hydrawise default scan interval#85398
MartinHjelmare merged 1 commit into
home-assistant:devfrom
mobilutz:patch-1

Conversation

@mobilutz
Copy link
Copy Markdown
Contributor

@mobilutz mobilutz commented Jan 7, 2023

Proposed change

Hydrawise has added an API rate-limit, so that doing many requests to the API will run into a 429 error being send from hydrawise.

Screenshot 2023-01-07 at 21 40 36
Screenshot 2023-01-07 at 21 40 43

It would be better to catch this HTTP errors, but as I have not written any code for HomeAssistant, I thought it would be best just to change this.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 7, 2023

Hi mobilutz

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 7, 2023

Hey there @ptcryan, mind taking a look at this pull request as it has been labeled with an integration (hydrawise) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hydrawise can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign hydrawise Removes the current integration label and assignees on the issue, add the integration domain after the command.

@elupus elupus added this to the 2023.1.2 milestone Jan 8, 2023
@MartinHjelmare MartinHjelmare changed the title [Hydrawise] Increasing default scan interval Increase Hydrawise default scan interval Jan 8, 2023
@MartinHjelmare MartinHjelmare merged commit 5d66349 into home-assistant:dev Jan 8, 2023
balloob pushed a commit that referenced this pull request Jan 9, 2023
Increasing default scan interval

Fixes #83540
@balloob balloob mentioned this pull request Jan 9, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hydrawise binary sensors and switches not available after 2022.12 update

4 participants