Skip to content

Address late feedback in SFR Box coordinator#85039

Merged
MartinHjelmare merged 2 commits into
home-assistant:devfrom
epenet:sfr_box_4
Jan 3, 2023
Merged

Address late feedback in SFR Box coordinator#85039
MartinHjelmare merged 2 commits into
home-assistant:devfrom
epenet:sfr_box_4

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Jan 3, 2023

Proposed change

Address late feedback from #84780 in SFR Box coordinator
cc @MartinHjelmare / @frenck

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Comment thread homeassistant/components/sfr_box/sensor.py
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 58b3651 into home-assistant:dev Jan 3, 2023
@epenet epenet deleted the sfr_box_4 branch January 3, 2023 12:54
mkmer pushed a commit to mkmer/HomeAssistant_Core that referenced this pull request Jan 3, 2023
* Address late feedback in SFR Box coordinator

* One more
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants