Add hs_command_template and xy_command_template to mqtt light default schema#84988
Merged
emontnemery merged 2 commits intoJan 3, 2023
Merged
Conversation
Contributor
|
Hi orosam It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Contributor
|
Hey there @emontnemery, @jbouwh, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
0aaeccf to
ba31b1d
Compare
Contributor
|
I've asked @emontnemery to also have a look |
emontnemery
approved these changes
Jan 3, 2023
Contributor
emontnemery
left a comment
There was a problem hiding this comment.
Thanks @orosam 👍
Congrats on the 1st Home Assistant PR 🎉
Contributor
Author
|
Thanks for the quick review & merge! |
mkmer
pushed a commit
to mkmer/HomeAssistant_Core
that referenced
this pull request
Jan 3, 2023
… schema (home-assistant#84988) * Add mqtt light hs_command_template * Add mqtt light xy_command_template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Zigbee lights connected to a tasmotized zbbridge need a specially formatted JSON message sent to a general command topic, where the color can only be set by either its XY value, or by its hue and saturation.
For example, to set the light color to fully saturated cyan, the following message has to be sent to
cmnd/myzbbridge/ZbSend:{ "Device": "My_Light", "Send": {"HueSat": "127,254" } }This PR adds the missing command templates for XY Color and HS Color to the MQTT light basic schema to allow controlling the color for these lights.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: