Skip to content

Add hs_command_template and xy_command_template to mqtt light default schema#84988

Merged
emontnemery merged 2 commits into
home-assistant:devfrom
orosam:mqtt-light-command-templates
Jan 3, 2023
Merged

Add hs_command_template and xy_command_template to mqtt light default schema#84988
emontnemery merged 2 commits into
home-assistant:devfrom
orosam:mqtt-light-command-templates

Conversation

@orosam
Copy link
Copy Markdown
Contributor

@orosam orosam commented Jan 2, 2023

Proposed change

Zigbee lights connected to a tasmotized zbbridge need a specially formatted JSON message sent to a general command topic, where the color can only be set by either its XY value, or by its hue and saturation.

For example, to set the light color to fully saturated cyan, the following message has to be sent to cmnd/myzbbridge/ZbSend:
{ "Device": "My_Light", "Send": {"HueSat": "127,254" } }

This PR adds the missing command templates for XY Color and HS Color to the MQTT light basic schema to allow controlling the color for these lights.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 2, 2023

Hi orosam

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 2, 2023

Hey there @emontnemery, @jbouwh, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the issue, add the integration domain after the command.

@orosam orosam force-pushed the mqtt-light-command-templates branch from 0aaeccf to ba31b1d Compare January 2, 2023 15:33
@orosam orosam marked this pull request as ready for review January 2, 2023 15:35
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straight forward,
Thx @orosam !

@jbouwh
Copy link
Copy Markdown
Contributor

jbouwh commented Jan 2, 2023

I've asked @emontnemery to also have a look

Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @orosam 👍

Congrats on the 1st Home Assistant PR 🎉

@emontnemery emontnemery merged commit a0d41e1 into home-assistant:dev Jan 3, 2023
@orosam
Copy link
Copy Markdown
Contributor Author

orosam commented Jan 3, 2023

Thanks for the quick review & merge!

mkmer pushed a commit to mkmer/HomeAssistant_Core that referenced this pull request Jan 3, 2023
… schema (home-assistant#84988)

* Add mqtt light hs_command_template

* Add mqtt light xy_command_template
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants