Skip to content

Address late feedback in SFR Box enum sensors #84977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epenet merged 4 commits into from
Jan 6, 2023
Merged

Address late feedback in SFR Box enum sensors #84977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
117c2bc
Address late feedback to SFR Box
epenet Jan 2, 2023
157af37
Hassfest
epenet Jan 6, 2023
35ac250
missed a capital G
epenet Jan 6, 2023
57355a0
Apply suggestion
epenet Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions homeassistant/components/sfr_box/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,15 @@ class SFRBoxSensorEntityDescription(SensorEntityDescription, SFRBoxSensorMixin):
entity_category=EntityCategory.DIAGNOSTIC,
entity_registry_enabled_default=False,
options=[
"No Defect",
"Of Frame",
"Loss Of Signal",
"Loss Of Power",
"Loss Of Signal Quality",
"Unknown",
"no_defect",
"of_frame",
"loss_of_signal",
"loss_of_power",
"loss_of_signal_quality",
"unknown",
],
value_fn=lambda x: x.line_status,
translation_key="line_status",
value_fn=lambda x: x.line_status.lower().replace(" ", "_"),
Comment thread
MartinHjelmare marked this conversation as resolved.
),
SFRBoxSensorEntityDescription(
key="training",
Expand All @@ -136,18 +137,19 @@ class SFRBoxSensorEntityDescription(SensorEntityDescription, SFRBoxSensorMixin):
entity_category=EntityCategory.DIAGNOSTIC,
entity_registry_enabled_default=False,
options=[
"Idle",
"G.994 Training",
"G.992 Started",
"G.922 Channel Analysis",
"G.992 Message Exchange",
"G.993 Started",
"G.993 Channel Analysis",
"G.993 Message Exchange",
"Showtime",
"Unknown",
"idle",
"g_994_training",
"g_992_started",
"g_922_channel_analysis",
"g_992_message_exchange",
"g_993_started",
"g_993_channel_analysis",
"g_993_message_exchange",
"showtime",
"unknown",
],
value_fn=lambda x: x.training,
translation_key="training",
value_fn=lambda x: x.training.lower().replace(" ", "_").replace(".", "_"),
),
)

Expand Down
28 changes: 28 additions & 0 deletions homeassistant/components/sfr_box/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,33 @@
"abort": {
"already_configured": "[%key:common::config_flow::abort::already_configured_device%]"
}
},
"entity": {
"sensor": {
"line_status": {
"state": {
"no_defect": "No Defect",
"of_frame": "Of Frame",
"loss_of_signal": "Loss Of Signal",
"loss_of_power": "Loss Of Power",
"loss_of_signal_quality": "Loss Of Signal Quality",
"unknown": "Unknown"
}
},
"training": {
"state": {
"idle": "Idle",
"g_994_training": "G.994 Training",
"g_992_started": "G.992 Started",
"g_922_channel_analysis": "G.922 Channel Analysis",
"g_992_message_exchange": "G.992 Message Exchange",
"g_993_started": "G.993 Started",
"g_993_channel_analysis": "G.993 Channel Analysis",
"g_993_message_exchange": "G.993 Message Exchange",
"showtime": "Showtime",
"unknown": "Unknown"
}
}
}
}
}
28 changes: 28 additions & 0 deletions homeassistant/components/sfr_box/translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,33 @@
}
}
}
},
"entity": {
"sensor": {
"line_status": {
"state": {
"no_defect": "No Defect",
"of_frame": "Of Frame",
"loss_of_signal": "Loss Of Signal",
"loss_of_power": "Loss Of Power",
"loss_of_signal_quality": "Loss Of Signal Quality",
"unknown": "Unknown"
}
},
"training": {
"state": {
"idle":"Idle",
"g_994_training":"G.994 Training",
"g_992_started":"G.992 Started",
"g_922_channel_analysis":"G.922 Channel Analysis",
"g_992_message_exchange":"G.992 Message Exchange",
"g_993_started":"G.993 Started",
"g_993_channel_analysis":"G.993 Channel Analysis",
"g_993_message_exchange":"G.993 Message Exchange",
"showtime":"Showtime",
"unknown":"Unknown"
}
}
}
}
}